Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests/lwip: blacklist nucleo-f302r8 #14290

Merged
merged 1 commit into from
Jun 15, 2020
Merged

tests/lwip: blacklist nucleo-f302r8 #14290

merged 1 commit into from
Jun 15, 2020

Conversation

fjmolinas
Copy link
Contributor

Contribution description

The application is failing to compile for this platform because its too large. It got by murdock because of #14264. So blacklist

Testing procedure

make -Ctests/lwip BOARD=nucleo-f302r8 all fails on master, won't be built with this PR.

Issues/PRs references

#14246 failed because of this: https://ci.riot-os.org/RIOT-OS/RIOT/14246/ac9eeb78ffc98fc715e255465e40fb7e21bbbf3e/output/compile/tests/lwip/nucleo-f302r8:gnu.txt

@fjmolinas fjmolinas added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: tests Area: tests and testing framework Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs labels Jun 15, 2020
@fjmolinas fjmolinas requested a review from miri64 as a code owner June 15, 2020 12:46
leandrolanzieri
leandrolanzieri approved these changes Jun 15, 2020
View reviewed changes
Copy link
Contributor

@leandrolanzieri leandrolanzieri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK.

@leandrolanzieri leandrolanzieri merged commit 78f8cef into RIOT-OS:master Jun 15, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.07 milestone Jun 15, 2020
@leandrolanzieri leandrolanzieri added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines labels Jun 15, 2020
@miri64
Copy link
Member

miri64 commented Jun 16, 2020

Side note: BOARDS_INSUFFICIENT_MEMORY (build but don't link) and BOARDS_BLACKLIST (don't build, subsequently don't link) are two distinct list. When I saw the title of this PR pop-up in my notifications I was wondering, what would justify an addition to BOARDS_BLACKLIST for a single board ;-)

@fjmolinas
Copy link
Contributor Author

Side note: BOARDS_INSUFFICIENT_MEMORY (build but don't link) and BOARDS_BLACKLIST (don't build, subsequently don't link) are two distinct list. When I saw the title of this PR pop-up in my notifications I was wondering, what would justify an addition to BOARDS_BLACKLIST for a single board ;-)

Yes, when I was opening the PR and made the commit I had used the wrong name, i fixed the commit but no the title, sorry about that.

@fjmolinas fjmolinas deleted the pr_lwip_bl_nucleo_f302r8 branch July 31, 2020 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leandrolanzieri leandrolanzieri leandrolanzieri approved these changes

@miri64 miri64 Awaiting requested review from miri64

Assignees
No one assigned
Labels
Area: build system Area: Build system Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: skip compile test If set, CI server will run only non-compile jobs, but no compile jobs or their dependent jobs Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2020.07
Development

Successfully merging this pull request may close these issues.
3 participants
@fjmolinas @miri64 @leandrolanzieri