Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

boards/esp32-heltec-lora32-v2: enable sx1276 by default #13727

Merged
merged 1 commit into from
Mar 26, 2020
Merged

boards/esp32-heltec-lora32-v2: enable sx1276 by default #13727

merged 1 commit into from
Mar 26, 2020

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Mar 26, 2020 •
edited
Loading

Contribution description

Now that #12994 is merged we can enable sx1276 in addition to esp_wifi by default.

Testing procedure

make -C examples/gnrc_networking BOARD=esp32-heltec-lora32-v2 flash term

both network Interfaces (esp_now and LoRA) should be available.

Issues/PRs references

follow-up on #11265

@benpicco
boards/esp32-heltec-lora32-v2: enable sx1276 by default
315d0be 
Now that RIOT-OS#12994 is merged we can enable sx1276 in addition to esp_wifi
by default.
@benpicco benpicco added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: boards Area: Board ports labels Mar 26, 2020
@benpicco benpicco requested a review from gschorcht March 26, 2020 13:47
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Mar 26, 2020
gschorcht
gschorcht approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@gschorcht gschorcht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small change that makes sense and work as expected.

@gschorcht gschorcht added Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines labels Mar 26, 2020
@gschorcht gschorcht merged commit 267433b into RIOT-OS:master Mar 26, 2020
@gschorcht
Copy link
Contributor

@benpicco Thanks for the contribution.

@benpicco benpicco deleted the boards/esp32-heltec-lora32-v2_sx1276 branch March 26, 2020 15:26
@leandrolanzieri leandrolanzieri added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Apr 3, 2020
@leandrolanzieri leandrolanzieri added this to the Release 2020.04 milestone Apr 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gschorcht gschorcht gschorcht approved these changes

Assignees
No one assigned
Labels
Area: boards Area: Board ports CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Reviewed: 1-fundamentals The fundamentals of the PR were reviewed according to the maintainer guidelines Reviewed: 2-code-design The code design of the PR was reviewed according to the maintainer guidelines Reviewed: 3-testing The PR was tested according to the maintainer guidelines Reviewed: 4-code-style The adherence to coding conventions by the PR were reviewed according to the maintainer guidelines Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Milestone
Release 2020.04
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @gschorcht @leandrolanzieri