gnrc_netif: remove netdev dependency #13614
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jia200x
added
Area: network
jia200x
requested review from
aabadie,
cgundogan,
gschorcht,
maribu and
PeterKietzmann
as code owners
miri64
reviewed
Mar 11, 2020
4 tasks
|
This PR will become more important now since #14950 is already there. |
jia200x
force-pushed
the
pr/gnrc_netif_netdev_dep
branch
from
dd2ad70
to
4649c2d
Compare
|
This needs a rebase. |
jia200x
force-pushed
the
pr/gnrc_netif_netdev_dep
branch
from
4649c2d
to
4749505
Compare
jia200x
force-pushed
the
pr/gnrc_netif_netdev_dep
branch
from
4749505
to
fc713b6
Compare
|
Done! After some days of heavy rebase |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
stale
bot
added
the
State: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR removes the strict dependency between
gnrc_netifandnetdev.This allows the usage of non-netdev link layers/devices for GNRC without adding dummy netdev handlers (e.g https://github.com/RIOT-OS/RIOT/blob/master/pkg/nimble/netif/nimble_netif.c#L278).
Testing procedure
This should be carefully tested. All
gnrc_netifimplementation (eth, esp, nimble, lorawan, etc) should still work. Maybe running the Release Tests could be a good idea.Issues/PRs references
Depends on #13608