Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

examples/suit_update:enable murdock #12563

Merged
merged 1 commit into from
Oct 24, 2019
Merged

Conversation

fjmolinas
Copy link
Contributor

@fjmolinas fjmolinas commented Oct 24, 2019

Contribution description

Now that #12408 is in, the test should work reliably in murdock and it should always answer to aiocoap with the EUI64 link local address, which is the first one, there should be no issue anymore where it answers with the EUI64 to a request to fe80::2 (this can happen the other way arround).

For details see #11818 (comment)

Testing procedure

  • run the test multiple times since the issue did not appear all the time.
sudo dist/tools/ethos/setup_network.sh riot0 2001:db8:/64
make -C examples/suit_update/ flash-only -j3 test 
suit_v4_parse() success
SUIT policy check OK.
suit_coap: finalizing image flash
riotboot_flashwrite: riotboot flashing completed successfully
Image magic_number: 0x544f4952
Image Version: 0x5db1c077
Image start address: 0x00001100
Header chksum: 0x9a6dccca

----> ethos: hello received
Failed to send flush request: Operation not permitted
gnrc_uhcpc: Using 5 as border interface and 0 as wireless interface.
gnrc_uhcpc: only one interface found, skipping setup.
main(): This is RIOT! (Version: 2020.01-devel-307-gce366-pr_enable_suit)
RIOT SUIT update example application
running from slot 0
TEST PASSED
  • murdock should be happy

Issues/PRs references

#11818

@fjmolinas fjmolinas added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Area: OTA Area: Over-the-air updates CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before labels Oct 24, 2019
Copy link
Contributor

@aabadie aabadie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test has run in a loop without any issue during 10 minutes (and is still running) so there's no issue on that side.

I guess that if Murdock is green, we can merge this one.

ACK

@aabadie
Copy link
Contributor

aabadie commented Oct 24, 2019

All green, let's go!

@aabadie aabadie merged commit 0946605 into RIOT-OS:master Oct 24, 2019
@fjmolinas fjmolinas deleted the pr_enable_suit branch December 1, 2019 14:17
@fjmolinas fjmolinas added this to the Release 2020.01 milestone Dec 13, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: OTA Area: Over-the-air updates CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants