Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nRF52: gnrc_6lowpan_ble: memory leak with nordic_softdevice_ble #6018

Closed
jfbortolotti opened this issue Oct 29, 2016 · 17 comments
Closed

nRF52: gnrc_6lowpan_ble: memory leak with nordic_softdevice_ble #6018

jfbortolotti opened this issue Oct 29, 2016 · 17 comments
Assignees
Labels
Area: BLE Area: Bluetooth Low Energy support Area: drivers Area: Device drivers Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Comments

@jfbortolotti
Copy link
Contributor

In case of Tx conflict on the ble interface, the _send function of gnrc_nordic_ble_6lowpan.c will return an -EBUSY error but no one handling the GNRC_NETAPI_MSG_TYPE_SND will take care of the error and what needs to be done for the packet(free or requeue).
This packet will stay in the alloc buffer.
After some time, if such conflicts happened, the memory allocated will continue to grow till the gnrc packet buffer will be full.
This can be reproduced with the microcoap_server example and sending pings forever. At some point, the buffer will be full and the stack will not be able to handle the ping echo request and reply at all.

One easy workaround is to accept to loose packet when there is such conflict and freeing up the packet.
In https://github.com/RIOT-OS/RIOT/blob/master/pkg/nordic_softdevice_ble/src/gnrc_nordic_ble_6lowpan.c#L139
add a call to release the gnrc packet buffer:
if (ble_mac_busy_tx) {
DEBUG("_send(): ble_mac_busy_tx, dropping packet\n");
gnrc_pktbuf_release(pkt);
return -EBUSY;
}

With such "ugly" workaround, the memory leak will be dramatically reduced and the stack will be able to handle more than 5000 pings without memory allocation issue.
There is simlar memory leak in case of -EBADMSG : https://github.com/RIOT-OS/RIOT/blob/master/pkg/nordic_softdevice_ble/src/gnrc_nordic_ble_6lowpan.c#L149

One better approach will be to requeue the GNRC_NETAPI_MSG_TYPE_SND message for retransmission. This could be done either the _send function or the _gnrc_nordic_ble_6lowpan_thread main loop by handling the different errors returned by _send.

Looking for feedback on the recommendation for properly fixing this.

Note:
1/ to get ping stability, you will need a fix or workaround regarding the uart_write function depending on how much debug you have activated. See #5954 .
2/ there is still a remaining memory leak after this, not yet understood by with a lot lower magnitude because it is only 8bytes once in a while and there is usually an hard_fault happening before the memory allocation buffer is full.

@OlegHahm OlegHahm added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: network Area: Networking Area: drivers Area: Device drivers Area: BLE Area: Bluetooth Low Energy support labels Oct 30, 2016
@OlegHahm OlegHahm added this to the Release 2016.10 milestone Oct 30, 2016
miri64 added a commit that referenced this issue Nov 11, 2016
RIOT-2016.10 - Release Notes
============================
RIOT is a real-time multi-threading operating system that supports a range of
devices that are typically found in the Internet of Things: 8-bit
microcontrollers, 16-bit microcontrollers and light-weight 32-bit processors.

RIOT is based on the following design principles: energy-efficiency, real-time
capabilities, small memory footprint, modularity, and uniform API access,
independent of the underlying hardware (this API offers partial POSIX
compliance).

RIOT is developed by an international open source community which is
independent of specific vendors (e.g. similarly to the Linux community) and is
licensed with a non-viral copyleft license (LGPLv2.1), which allows indirect
business models around the free open-source software platform provided by
RIOT.

About this release:
===================
This release provides a lot of new features as well as it  fixes several major
bugs. Among these new features are the new simplified network socket API
called sock, the GNRC specific CoAP implementation gcoap and several new
packages: TinyDTLS, the Aversive++ microcontroller library for robotics, the
u8g2 graphic library, and nanocoap.
Using the new sock API an implementation of the Simple Time Network Protocol
(SNTP) was also introduced, allowing for time synchronization between nodes.
New platforms include the Arduino Uno, the Arduino Duemilanove, the Arduino
Zero, SODAQ Autonomo, and the Zolertia remote (rev. B).
The most significant bug fix was done in native which led to a significantly
more robust handling of ISRs and now allows for at least 1,000 native
instances running stably on one machine.

About 263 pull requests with about 398 commits have been merged since the last
release and about 42 issues have been solved. 37 people contributed with code
in 100 days. 1006 files have been touched with 166500 insertions and 26926
deletions.

Notations used below:
=====================
+ means new feature/item
* means modified feature/item
- means removed feature/item

New features and changes
========================
General
-------
* Verbose behavior for assert() macro

Core
----
+ MPU support for Cortex-M

API changes
-----------
+ Socket-like sock API (replacing conn)
* netdev2: Add Testmodes and CCA modes
* IEEE 802.15.4: clean-up Intra-PAN behavior
* IEEE 802.15.4: centralize default values
* gnrc_pktbuf: allow for 0-sized snips
+ gnrc_netapi: mbox and arbitrary callback support

System libraries
----------------
No new features or changes

Networking
----------
+ Provide sock-port for GNRC
+ gcoap: a GNRC-based CoAP implementation
+ Simple Network Time Protocol (RFC 5905, section 14)
+ Priority Queue for packet snips
+ IPv4 header definitions

Packages
--------
+ nanocoap: CoAP header parser/builder
+ TinyDTLS: DTLS library
+ tiny-asn1: asn.1/der decoder
+ Aversive++ microcontroller programming library
+ u8g2 graphic library

Platforms
---------
+ Support for stm32f2xx MCU family
+ Low power modes for samd21 CPUs
+ More Arduino-based platforms:
    + Arduino Uno
    + Arduino Duemilanove
    + Arduino Zero
+ More boards of ST's Nucleo platforms:
    + ST Nucleo F030 board support
    + ST Nucleo F070 board support
    + ST Nucleo F446 board support
+ SODAQ Automono
+ Zolertia remote rev. B

Drivers
-------
+ W5100 Ethernet device
+ Atmel IO1 Xplained extension
+ LPD8808 LED strips
* at86rf2xx: provide capability to access the RND_VALUE random value register

Build System
------------
+ static-tests build target for easy local execution of CI's static tests

Other
-----
+ Provide Arduino API to Nucleo boards
+ Packer configuration file to build vagrant boxes
+ CC2650STK Debugger Support
+ ethos: add Ethos over TCP support

Fixed Issues from the last release
==================================
 #534:  native debugging on osx fails
 #2071: native: *long* overdue fixes
 #3341: netdev2_tap crashes when hammered
 #5007: gnrc icmpv6: Ping reply goes out the wrong interface
 #5432: native: valgrind fails

Known Issues
============
Networking related issues
-------------------------
 #3075: nhdp: unnecessary microsecond precision: NHDP works with timer values
       of microsecond precision which is not required. Changing to lower
       precision would save some memory.
 #4048: potential racey memory leak: According to the packet buffer stats,
       flood-pinging a multicast destination may lead to a memory leak due to
       a race condition. However, it seems to be a rare case and a completely
       filled up packet buffer was not observed.
 #4388: POSIX sockets: open socket is bound to a specific thread: This was an
       inherit problem of the conn API under GNRC. Since the POSIX sockets are
       still based on conn for this release, this issue persists
 #4527: gnrc_ipv6: Multicast is not forwarded if routing node listens to the
       address (might still be fixable for release, see #5729, #5230: gnrc
       ipv6: multicast packets are not dispatched to the upper layers)
 #5016: gnrc_rpl: Rejoining RPL instance as root after reboot messes up routing
 #5055: cpuid: multiple radios will get same EUI-64 Nodes with multiple
       interfaces might get the same EUI-64 for them since they are generated
       from the same CPU ID.
 #5656: Possible Weakness with locking in the GNRC network stack: For some
       operations mutexes to the network interfaces need to get unlocked in
       the current implementation to not get deadlocked. Recursive mutexes as
       provided in #5731 might help to solve this problem.
 #5748: gnrc: nodes crashing with too small packet buffer: A packet buffer of
       size ~512 B might lead to crashes. The issue describes this for several
       hundret nodes, but agressive flooding with just two nodes was also
       shown to lead to this problem.
 #5858: gnrc: 6lo: potential problem with reassembly of fragments: If one frame
       gets lost the reassembly state machine might get out of sync

 ### NDP is not working properly
 #4499: handle of l2src_len in gnrc_ndp_rtr_sol_handle: Reception of a router
       solicitation might lead to invalid zero-length link-layer addresses in
       neighbor cache.
 #5005: ndp: router advertisement sent with global address: Under some
       circumstances a router might send RAs with GUAs. While they are ignored
       on receive (as RFC 4861 specifies), RAs should have link-local
       addresses and not even be send out this way.
 #5122: NDP: global unicast address on non-6LBR nodes disappears after a while:
       Several issues (also see #5760) lead to a global unicast address
       effectively being banned from the network (disappears from neighbor
       cache, is not added again)
 #5467: ipv6 address vanishes when ARO (wrongly) indicates DUP caused by
       outdated ncache at router
 #5539: Border Router: packet not forwarded from ethos to interface 6
 #5790: ND: Lost of Global IPV6 on node after sending lot of UDP frame from BR

Timer related issues
--------------------
 #4841: xtimer: timer already in the list: Under some conditions an xtimer can
       end up twice in the internal list of the xtimer module
 #4902: xtimer: xtimer_set: xtimer_set does not handle integer overflows well
 #5338: xtimer: xtimer_now() not ISR safe for non-32-bit platforms.
 #5928: xtimer: usage in board_init() crashes: some boards use the xtimer in
       there board_init() function. The xtimer is however first initialized in
       the auto_init module which is executed after board_init()
 #6052: tests: xtimer_drift gets stuck: xtimer_drift application freezes after
       ~30-200 seconds

native related issues
---------------------
 #495:  native not float safe: When the FPU is used when an asynchronous context
       switch occurs, either the stack gets corrupted or a floating point
       exception occurs.
 #2175: ubjson: valgind registers "Invalid write of size 4" in unittests
 #4590: pkg: building relic with clang fails.
 #5796: native: tlsf: early malloc will lead to a crash: TLSF needs pools to be
       initialized (which is currently expected to be done in an application).
       If a malloc is needed before an application's main started (e.g. driver
       initialization) the node can crash, since no pool is allocated yet.

other platform related issues
-----------------------------
 #1891: newlib-nano: Printf formatting does not work properly for some numberic
       types: PRI[uxdi]64, PRI[uxdi]8 and float are not parsed in newlib-nano
 #2006: cpu/nrf51822: timer callback may be fired too early
 #2143: unittests: tests-core doesn't compile for all platforms: GCC build-ins
       were used in the unittests which are not available with msp430-gcc
 #2300: qemu unittest fails because of a page fault
 #4512: pkg: tests: RELIC unittests fail on iotlab-m3
 #4522: avsextrem: linker sometimes doesn't find `bl_init_clks()`
 #4560: make: clang is more pedantic than gcc oonf_api is not building with
       clang. (Partly solved by #4593)
 #4694: drivers/lm75a: does not build
 #4737: cortex-m: Hard fault after a thread exits (under some circumstances)
 #4822: kw2xrf: packet loss when packets get fragmented
 #4876: at86rf2xx: Simultaneous use of different transceiver types is not
       supported
 #4954: chronos: compiling with -O0 breaks
 #4866: not all GPIO driver implementations are thread safe: Due to non-atomic
       operations in the drivers some pin configurations might get lost.
 #5009: RIOT is saw-toothing in energy consumption (even when idling)
 #5103: xtimer: weird behavior of tests/xtimer_drift: xtimer_drift randomly
       jumps a few seconds on nrf52
 #5361: cpu/cc26x0: timer broken
 #5405: Eratic timings on iotlab-m3 with compression context activated
 #5460: cpu/samd21: i2c timing with compiler optimization
 #5486: at86rf2xx: lost interrupts
 #5489: cpu/lpc11u34: ADC broken
 #5603: atmega boards second UART issue
 #5678: at86rf2xx: failed assertion in _isr
 #5719: cc2538: rf driver doesn't handle large packets
 #5799: kw2x: 15.4 duplicate transmits
 #5944: msp430: ipv6_hdr unittests fail
 #5848: arduino: Race condition in sys/arduino/Makefile.include
 #5954: nRF52 uart_write get stuck
 #6018: nRF52 gnrc 6lowpan ble memory leak

other issues
------------
 #1263: TLSF implementation contains (a) read-before-write error(s).
 #3256: make: Setting constants on compile time doesn't really set them
       everywhere
 #3366: periph/i2c: handle NACK
 #4488: Making the newlib thread-safe: When calling puts/printf after
       thread_create(), the CPU hangs for DMA enabled uart drivers.
 #4866: periph: GPIO drivers are not thread safe
 #5128: make: buildtest breaks when exporting FEATURES_PROVIDED var
 #5207: make: buildest fails with board dependent application Makefiles
 #5390: pkg: OpenWSN does not compile: This package still uses deprecated
       modules and was not tested for a long time.
 #5520: tests/periph_uart not working
 #5561: C++11 extensions in header files
 #5776: make: Predefining CFLAGS are parsed weirdly
 #5863: OSX +  SAMR21-xpro: shell cannot handle command inputs larger than 64
       chars
 #5962: Makefile: UNDEF variable is not working as documented
 #6022: pkg: build order issue

Special Thanks
==============
We like to give our special thanks to all the companies that provided us with
their hardware for porting and testing, namely the people from (in
alphabeticalorder): Atmel, Freescale, Imagination Technologies, Limifrog,
Nordic, OpenMote, Phytec, SiLabs, UDOO,and Zolertia; and also companies that
directly sponsored development time: Cisco Systems, Eistec, Ell-i, Enigeering
Spirit, Nordic, FreshTemp LLC, OTAkeys and Phytec.

More information
================
http://www.riot-os.org

Mailing lists
-------------
* RIOT OS kernel developers list
  [email protected] (http://lists.riot-os.org/mailman/listinfo/devel)
* RIOT OS users list
  [email protected] (http://lists.riot-os.org/mailman/listinfo/users)
* RIOT commits
  [email protected] (http://lists.riot-os.org/mailman/listinfo/commits)
* Github notifications
  [email protected] (http://lists.riot-os.org/mailman/listinfo/notifications)

IRC
---
* Join the RIOT IRC channel at: irc.freenode.net, #riot-os

License
=======
* Most of the code developed by the RIOT community is licensed under the GNU
  Lesser General Public License (LGPL) version 2.1 as published by the Free
  Software Foundation.
* Some external sources are published under a separate, LGPL compatible
  license (e.g. some files developed by SICS).

All code files contain licensing information.
miri64 added a commit that referenced this issue Nov 11, 2016
RIOT-2016.10 - Release Notes
============================
RIOT is a real-time multi-threading operating system that supports a range of
devices that are typically found in the Internet of Things: 8-bit
microcontrollers, 16-bit microcontrollers and light-weight 32-bit processors.

RIOT is based on the following design principles: energy-efficiency, real-time
capabilities, small memory footprint, modularity, and uniform API access,
independent of the underlying hardware (this API offers partial POSIX
compliance).

RIOT is developed by an international open source community which is
independent of specific vendors (e.g. similarly to the Linux community) and is
licensed with a non-viral copyleft license (LGPLv2.1), which allows indirect
business models around the free open-source software platform provided by
RIOT.

About this release:
===================
This release provides a lot of new features as well as it  fixes several major
bugs. Among these new features are the new simplified network socket API
called sock, the GNRC specific CoAP implementation gcoap and several new
packages: TinyDTLS, the Aversive++ microcontroller library for robotics, the
u8g2 graphic library, and nanocoap.
Using the new sock API an implementation of the Simple Time Network Protocol
(SNTP) was also introduced, allowing for time synchronization between nodes.
New platforms include the Arduino Uno, the Arduino Duemilanove, the Arduino
Zero, SODAQ Autonomo, and the Zolertia remote (rev. B).
The most significant bug fix was done in native which led to a significantly
more robust handling of ISRs and now allows for at least 1,000 native
instances running stably on one machine.

About 263 pull requests with about 398 commits have been merged since the last
release and about 42 issues have been solved. 37 people contributed with code
in 100 days. 1006 files have been touched with 166500 insertions and 26926
deletions.

Notations used below:
=====================
+ means new feature/item
* means modified feature/item
- means removed feature/item

New features and changes
========================
General
-------
* Verbose behavior for assert() macro

Core
----
+ MPU support for Cortex-M

API changes
-----------
+ Socket-like sock API (replacing conn)
* netdev2: Add Testmodes and CCA modes
* IEEE 802.15.4: clean-up Intra-PAN behavior
* IEEE 802.15.4: centralize default values
* gnrc_pktbuf: allow for 0-sized snips
+ gnrc_netapi: mbox and arbitrary callback support

System libraries
----------------
No new features or changes

Networking
----------
+ Provide sock-port for GNRC
+ gcoap: a GNRC-based CoAP implementation
+ Simple Network Time Protocol (RFC 5905, section 14)
+ Priority Queue for packet snips
+ IPv4 header definitions

Packages
--------
+ nanocoap: CoAP header parser/builder
+ TinyDTLS: DTLS library
+ tiny-asn1: asn.1/der decoder
+ Aversive++ microcontroller programming library
+ u8g2 graphic library

Platforms
---------
+ Support for stm32f2xx MCU family
+ Low power modes for samd21 CPUs
+ More Arduino-based platforms:
    + Arduino Uno
    + Arduino Duemilanove
    + Arduino Zero
+ More boards of ST's Nucleo platforms:
    + ST Nucleo F030 board support
    + ST Nucleo F070 board support
    + ST Nucleo F446 board support
+ SODAQ Automono
+ Zolertia remote rev. B

Drivers
-------
+ W5100 Ethernet device
+ Atmel IO1 Xplained extension
+ LPD8808 LED strips
* at86rf2xx: provide capability to access the RND_VALUE random value register

Build System
------------
+ static-tests build target for easy local execution of CI's static tests

Other
-----
+ Provide Arduino API to Nucleo boards
+ Packer configuration file to build vagrant boxes
+ CC2650STK Debugger Support
+ ethos: add Ethos over TCP support

Fixed Issues from the last release
==================================
 #534:  native debugging on osx fails
 #2071: native: *long* overdue fixes
 #3341: netdev2_tap crashes when hammered
 #5007: gnrc icmpv6: Ping reply goes out the wrong interface
 #5432: native: valgrind fails

Known Issues
============
Networking related issues
-------------------------
 #3075: nhdp: unnecessary microsecond precision: NHDP works with timer values
       of microsecond precision which is not required. Changing to lower
       precision would save some memory.
 #4048: potential racey memory leak: According to the packet buffer stats,
       flood-pinging a multicast destination may lead to a memory leak due to
       a race condition. However, it seems to be a rare case and a completely
       filled up packet buffer was not observed.
 #4388: POSIX sockets: open socket is bound to a specific thread: This was an
       inherit problem of the conn API under GNRC. Since the POSIX sockets are
       still based on conn for this release, this issue persists
 #4527: gnrc_ipv6: Multicast is not forwarded if routing node listens to the
       address (might still be fixable for release, see #5729, #5230: gnrc
       ipv6: multicast packets are not dispatched to the upper layers)
 #5016: gnrc_rpl: Rejoining RPL instance as root after reboot messes up routing
 #5055: cpuid: multiple radios will get same EUI-64 Nodes with multiple
       interfaces might get the same EUI-64 for them since they are generated
       from the same CPU ID.
 #5656: Possible Weakness with locking in the GNRC network stack: For some
       operations mutexes to the network interfaces need to get unlocked in
       the current implementation to not get deadlocked. Recursive mutexes as
       provided in #5731 might help to solve this problem.
 #5748: gnrc: nodes crashing with too small packet buffer: A packet buffer of
       size ~512 B might lead to crashes. The issue describes this for several
       hundret nodes, but agressive flooding with just two nodes was also
       shown to lead to this problem.
 #5858: gnrc: 6lo: potential problem with reassembly of fragments: If one frame
       gets lost the reassembly state machine might get out of sync

 ### NDP is not working properly
 #4499: handle of l2src_len in gnrc_ndp_rtr_sol_handle: Reception of a router
       solicitation might lead to invalid zero-length link-layer addresses in
       neighbor cache.
 #5005: ndp: router advertisement sent with global address: Under some
       circumstances a router might send RAs with GUAs. While they are ignored
       on receive (as RFC 4861 specifies), RAs should have link-local
       addresses and not even be send out this way.
 #5122: NDP: global unicast address on non-6LBR nodes disappears after a while:
       Several issues (also see #5760) lead to a global unicast address
       effectively being banned from the network (disappears from neighbor
       cache, is not added again)
 #5467: ipv6 address vanishes when ARO (wrongly) indicates DUP caused by
       outdated ncache at router
 #5539: Border Router: packet not forwarded from ethos to interface 6
 #5790: ND: Lost of Global IPV6 on node after sending lot of UDP frame from BR

Timer related issues
--------------------
 #4841: xtimer: timer already in the list: Under some conditions an xtimer can
       end up twice in the internal list of the xtimer module
 #4902: xtimer: xtimer_set: xtimer_set does not handle integer overflows well
 #5338: xtimer: xtimer_now() not ISR safe for non-32-bit platforms.
 #5928: xtimer: usage in board_init() crashes: some boards use the xtimer in
       there board_init() function. The xtimer is however first initialized in
       the auto_init module which is executed after board_init()
 #6052: tests: xtimer_drift gets stuck: xtimer_drift application freezes after
       ~30-200 seconds

native related issues
---------------------
 #495:  native not float safe: When the FPU is used when an asynchronous context
       switch occurs, either the stack gets corrupted or a floating point
       exception occurs.
 #2175: ubjson: valgind registers "Invalid write of size 4" in unittests
 #4590: pkg: building relic with clang fails.
 #5796: native: tlsf: early malloc will lead to a crash: TLSF needs pools to be
       initialized (which is currently expected to be done in an application).
       If a malloc is needed before an application's main started (e.g. driver
       initialization) the node can crash, since no pool is allocated yet.

other platform related issues
-----------------------------
 #1891: newlib-nano: Printf formatting does not work properly for some numberic
       types: PRI[uxdi]64, PRI[uxdi]8 and float are not parsed in newlib-nano
 #2006: cpu/nrf51822: timer callback may be fired too early
 #2143: unittests: tests-core doesn't compile for all platforms: GCC build-ins
       were used in the unittests which are not available with msp430-gcc
 #2300: qemu unittest fails because of a page fault
 #4512: pkg: tests: RELIC unittests fail on iotlab-m3
 #4522: avsextrem: linker sometimes doesn't find `bl_init_clks()`
 #4560: make: clang is more pedantic than gcc oonf_api is not building with
       clang. (Partly solved by #4593)
 #4694: drivers/lm75a: does not build
 #4737: cortex-m: Hard fault after a thread exits (under some circumstances)
 #4822: kw2xrf: packet loss when packets get fragmented
 #4876: at86rf2xx: Simultaneous use of different transceiver types is not
       supported
 #4954: chronos: compiling with -O0 breaks
 #4866: not all GPIO driver implementations are thread safe: Due to non-atomic
       operations in the drivers some pin configurations might get lost.
 #5009: RIOT is saw-toothing in energy consumption (even when idling)
 #5103: xtimer: weird behavior of tests/xtimer_drift: xtimer_drift randomly
       jumps a few seconds on nrf52
 #5361: cpu/cc26x0: timer broken
 #5405: Eratic timings on iotlab-m3 with compression context activated
 #5460: cpu/samd21: i2c timing with compiler optimization
 #5486: at86rf2xx: lost interrupts
 #5489: cpu/lpc11u34: ADC broken
 #5603: atmega boards second UART issue
 #5678: at86rf2xx: failed assertion in _isr
 #5719: cc2538: rf driver doesn't handle large packets
 #5799: kw2x: 15.4 duplicate transmits
 #5944: msp430: ipv6_hdr unittests fail
 #5848: arduino: Race condition in sys/arduino/Makefile.include
 #5954: nRF52 uart_write get stuck
 #6018: nRF52 gnrc 6lowpan ble memory leak

other issues
------------
 #1263: TLSF implementation contains (a) read-before-write error(s).
 #3256: make: Setting constants on compile time doesn't really set them
       everywhere
 #3366: periph/i2c: handle NACK
 #4488: Making the newlib thread-safe: When calling puts/printf after
       thread_create(), the CPU hangs for DMA enabled uart drivers.
 #4866: periph: GPIO drivers are not thread safe
 #5128: make: buildtest breaks when exporting FEATURES_PROVIDED var
 #5207: make: buildest fails with board dependent application Makefiles
 #5390: pkg: OpenWSN does not compile: This package still uses deprecated
       modules and was not tested for a long time.
 #5520: tests/periph_uart not working
 #5561: C++11 extensions in header files
 #5776: make: Predefining CFLAGS are parsed weirdly
 #5863: OSX +  SAMR21-xpro: shell cannot handle command inputs larger than 64
       chars
 #5962: Makefile: UNDEF variable is not working as documented
 #6022: pkg: build order issue

Special Thanks
==============
We like to give our special thanks to all the companies that provided us with
their hardware for porting and testing, namely the people from (in
alphabeticalorder): Atmel, Freescale, Imagination Technologies, Limifrog,
Nordic, OpenMote, Phytec, SiLabs, UDOO,and Zolertia; and also companies that
directly sponsored development time: Cisco Systems, Eistec, Ell-i, Enigeering
Spirit, Nordic, FreshTemp LLC, OTAkeys and Phytec.

More information
================
http://www.riot-os.org

Mailing lists
-------------
* RIOT OS kernel developers list
  [email protected] (http://lists.riot-os.org/mailman/listinfo/devel)
* RIOT OS users list
  [email protected] (http://lists.riot-os.org/mailman/listinfo/users)
* RIOT commits
  [email protected] (http://lists.riot-os.org/mailman/listinfo/commits)
* Github notifications
  [email protected] (http://lists.riot-os.org/mailman/listinfo/notifications)

IRC
---
* Join the RIOT IRC channel at: irc.freenode.net, #riot-os

License
=======
* Most of the code developed by the RIOT community is licensed under the GNU
  Lesser General Public License (LGPL) version 2.1 as published by the Free
  Software Foundation.
* Some external sources are published under a separate, LGPL compatible
  license (e.g. some files developed by SICS).

All code files contain licensing information.
@miri64 miri64 modified the milestones: Release 2016.10, Release 2017.01 Nov 11, 2016
@kaspar030
Copy link
Contributor

Sorry for the delay.

One better approach will be to requeue the GNRC_NETAPI_MSG_TYPE_SND message for retransmission. This could be done either the _send function or the _gnrc_nordic_ble_6lowpan_thread main loop by handling the different errors returned by _send.

IMHO send would be the place to handle the error. I'd be fine with a workaround (make sure the packet always gets freed), but re-queuing is maybe not much more complicated to implement?

@jfbortolotti
Copy link
Contributor Author

Correct re-queuing may not be that complicated it will just take more time for me to figure it out and test it ...
If you can point me to some sample of code, I'll give it a try.
I can submit the workaround very quickly as I tested it already.

@kaspar030
Copy link
Contributor

I can submit the workaround very quickly as I tested it already.

Then let's go with the workaround and provide a proper fix later!

@kaspar030
Copy link
Contributor

One more idea: could we replace ble_mac_busy_tx with a mutex?

neiljay pushed a commit to neiljay/RIOT that referenced this issue Jan 16, 2017
RIOT-2016.10 - Release Notes
============================
RIOT is a real-time multi-threading operating system that supports a range of
devices that are typically found in the Internet of Things: 8-bit
microcontrollers, 16-bit microcontrollers and light-weight 32-bit processors.

RIOT is based on the following design principles: energy-efficiency, real-time
capabilities, small memory footprint, modularity, and uniform API access,
independent of the underlying hardware (this API offers partial POSIX
compliance).

RIOT is developed by an international open source community which is
independent of specific vendors (e.g. similarly to the Linux community) and is
licensed with a non-viral copyleft license (LGPLv2.1), which allows indirect
business models around the free open-source software platform provided by
RIOT.

About this release:
===================
This release provides a lot of new features as well as it  fixes several major
bugs. Among these new features are the new simplified network socket API
called sock, the GNRC specific CoAP implementation gcoap and several new
packages: TinyDTLS, the Aversive++ microcontroller library for robotics, the
u8g2 graphic library, and nanocoap.
Using the new sock API an implementation of the Simple Time Network Protocol
(SNTP) was also introduced, allowing for time synchronization between nodes.
New platforms include the Arduino Uno, the Arduino Duemilanove, the Arduino
Zero, SODAQ Autonomo, and the Zolertia remote (rev. B).
The most significant bug fix was done in native which led to a significantly
more robust handling of ISRs and now allows for at least 1,000 native
instances running stably on one machine.

About 263 pull requests with about 398 commits have been merged since the last
release and about 42 issues have been solved. 37 people contributed with code
in 100 days. 1006 files have been touched with 166500 insertions and 26926
deletions.

Notations used below:
=====================
+ means new feature/item
* means modified feature/item
- means removed feature/item

New features and changes
========================
General
-------
* Verbose behavior for assert() macro

Core
----
+ MPU support for Cortex-M

API changes
-----------
+ Socket-like sock API (replacing conn)
* netdev2: Add Testmodes and CCA modes
* IEEE 802.15.4: clean-up Intra-PAN behavior
* IEEE 802.15.4: centralize default values
* gnrc_pktbuf: allow for 0-sized snips
+ gnrc_netapi: mbox and arbitrary callback support

System libraries
----------------
No new features or changes

Networking
----------
+ Provide sock-port for GNRC
+ gcoap: a GNRC-based CoAP implementation
+ Simple Network Time Protocol (RFC 5905, section 14)
+ Priority Queue for packet snips
+ IPv4 header definitions

Packages
--------
+ nanocoap: CoAP header parser/builder
+ TinyDTLS: DTLS library
+ tiny-asn1: asn.1/der decoder
+ Aversive++ microcontroller programming library
+ u8g2 graphic library

Platforms
---------
+ Support for stm32f2xx MCU family
+ Low power modes for samd21 CPUs
+ More Arduino-based platforms:
    + Arduino Uno
    + Arduino Duemilanove
    + Arduino Zero
+ More boards of ST's Nucleo platforms:
    + ST Nucleo F030 board support
    + ST Nucleo F070 board support
    + ST Nucleo F446 board support
+ SODAQ Automono
+ Zolertia remote rev. B

Drivers
-------
+ W5100 Ethernet device
+ Atmel IO1 Xplained extension
+ LPD8808 LED strips
* at86rf2xx: provide capability to access the RND_VALUE random value register

Build System
------------
+ static-tests build target for easy local execution of CI's static tests

Other
-----
+ Provide Arduino API to Nucleo boards
+ Packer configuration file to build vagrant boxes
+ CC2650STK Debugger Support
+ ethos: add Ethos over TCP support

Fixed Issues from the last release
==================================
 RIOT-OS#534:  native debugging on osx fails
 RIOT-OS#2071: native: *long* overdue fixes
 RIOT-OS#3341: netdev2_tap crashes when hammered
 RIOT-OS#5007: gnrc icmpv6: Ping reply goes out the wrong interface
 RIOT-OS#5432: native: valgrind fails

Known Issues
============
Networking related issues
-------------------------
 RIOT-OS#3075: nhdp: unnecessary microsecond precision: NHDP works with timer values
       of microsecond precision which is not required. Changing to lower
       precision would save some memory.
 RIOT-OS#4048: potential racey memory leak: According to the packet buffer stats,
       flood-pinging a multicast destination may lead to a memory leak due to
       a race condition. However, it seems to be a rare case and a completely
       filled up packet buffer was not observed.
 RIOT-OS#4388: POSIX sockets: open socket is bound to a specific thread: This was an
       inherit problem of the conn API under GNRC. Since the POSIX sockets are
       still based on conn for this release, this issue persists
 RIOT-OS#4527: gnrc_ipv6: Multicast is not forwarded if routing node listens to the
       address (might still be fixable for release, see RIOT-OS#5729, RIOT-OS#5230: gnrc
       ipv6: multicast packets are not dispatched to the upper layers)
 RIOT-OS#5016: gnrc_rpl: Rejoining RPL instance as root after reboot messes up routing
 RIOT-OS#5055: cpuid: multiple radios will get same EUI-64 Nodes with multiple
       interfaces might get the same EUI-64 for them since they are generated
       from the same CPU ID.
 RIOT-OS#5656: Possible Weakness with locking in the GNRC network stack: For some
       operations mutexes to the network interfaces need to get unlocked in
       the current implementation to not get deadlocked. Recursive mutexes as
       provided in RIOT-OS#5731 might help to solve this problem.
 RIOT-OS#5748: gnrc: nodes crashing with too small packet buffer: A packet buffer of
       size ~512 B might lead to crashes. The issue describes this for several
       hundret nodes, but agressive flooding with just two nodes was also
       shown to lead to this problem.
 RIOT-OS#5858: gnrc: 6lo: potential problem with reassembly of fragments: If one frame
       gets lost the reassembly state machine might get out of sync

 ### NDP is not working properly
 RIOT-OS#4499: handle of l2src_len in gnrc_ndp_rtr_sol_handle: Reception of a router
       solicitation might lead to invalid zero-length link-layer addresses in
       neighbor cache.
 RIOT-OS#5005: ndp: router advertisement sent with global address: Under some
       circumstances a router might send RAs with GUAs. While they are ignored
       on receive (as RFC 4861 specifies), RAs should have link-local
       addresses and not even be send out this way.
 RIOT-OS#5122: NDP: global unicast address on non-6LBR nodes disappears after a while:
       Several issues (also see RIOT-OS#5760) lead to a global unicast address
       effectively being banned from the network (disappears from neighbor
       cache, is not added again)
 RIOT-OS#5467: ipv6 address vanishes when ARO (wrongly) indicates DUP caused by
       outdated ncache at router
 RIOT-OS#5539: Border Router: packet not forwarded from ethos to interface 6
 RIOT-OS#5790: ND: Lost of Global IPV6 on node after sending lot of UDP frame from BR

Timer related issues
--------------------
 RIOT-OS#4841: xtimer: timer already in the list: Under some conditions an xtimer can
       end up twice in the internal list of the xtimer module
 RIOT-OS#4902: xtimer: xtimer_set: xtimer_set does not handle integer overflows well
 RIOT-OS#5338: xtimer: xtimer_now() not ISR safe for non-32-bit platforms.
 RIOT-OS#5928: xtimer: usage in board_init() crashes: some boards use the xtimer in
       there board_init() function. The xtimer is however first initialized in
       the auto_init module which is executed after board_init()
 RIOT-OS#6052: tests: xtimer_drift gets stuck: xtimer_drift application freezes after
       ~30-200 seconds

native related issues
---------------------
 RIOT-OS#495:  native not float safe: When the FPU is used when an asynchronous context
       switch occurs, either the stack gets corrupted or a floating point
       exception occurs.
 RIOT-OS#2175: ubjson: valgind registers "Invalid write of size 4" in unittests
 RIOT-OS#4590: pkg: building relic with clang fails.
 RIOT-OS#5796: native: tlsf: early malloc will lead to a crash: TLSF needs pools to be
       initialized (which is currently expected to be done in an application).
       If a malloc is needed before an application's main started (e.g. driver
       initialization) the node can crash, since no pool is allocated yet.

other platform related issues
-----------------------------
 RIOT-OS#1891: newlib-nano: Printf formatting does not work properly for some numberic
       types: PRI[uxdi]64, PRI[uxdi]8 and float are not parsed in newlib-nano
 RIOT-OS#2006: cpu/nrf51822: timer callback may be fired too early
 RIOT-OS#2143: unittests: tests-core doesn't compile for all platforms: GCC build-ins
       were used in the unittests which are not available with msp430-gcc
 RIOT-OS#2300: qemu unittest fails because of a page fault
 RIOT-OS#4512: pkg: tests: RELIC unittests fail on iotlab-m3
 RIOT-OS#4522: avsextrem: linker sometimes doesn't find `bl_init_clks()`
 RIOT-OS#4560: make: clang is more pedantic than gcc oonf_api is not building with
       clang. (Partly solved by RIOT-OS#4593)
 RIOT-OS#4694: drivers/lm75a: does not build
 RIOT-OS#4737: cortex-m: Hard fault after a thread exits (under some circumstances)
 RIOT-OS#4822: kw2xrf: packet loss when packets get fragmented
 RIOT-OS#4876: at86rf2xx: Simultaneous use of different transceiver types is not
       supported
 RIOT-OS#4954: chronos: compiling with -O0 breaks
 RIOT-OS#4866: not all GPIO driver implementations are thread safe: Due to non-atomic
       operations in the drivers some pin configurations might get lost.
 RIOT-OS#5009: RIOT is saw-toothing in energy consumption (even when idling)
 RIOT-OS#5103: xtimer: weird behavior of tests/xtimer_drift: xtimer_drift randomly
       jumps a few seconds on nrf52
 RIOT-OS#5361: cpu/cc26x0: timer broken
 RIOT-OS#5405: Eratic timings on iotlab-m3 with compression context activated
 RIOT-OS#5460: cpu/samd21: i2c timing with compiler optimization
 RIOT-OS#5486: at86rf2xx: lost interrupts
 RIOT-OS#5489: cpu/lpc11u34: ADC broken
 RIOT-OS#5603: atmega boards second UART issue
 RIOT-OS#5678: at86rf2xx: failed assertion in _isr
 RIOT-OS#5719: cc2538: rf driver doesn't handle large packets
 RIOT-OS#5799: kw2x: 15.4 duplicate transmits
 RIOT-OS#5944: msp430: ipv6_hdr unittests fail
 RIOT-OS#5848: arduino: Race condition in sys/arduino/Makefile.include
 RIOT-OS#5954: nRF52 uart_write get stuck
 RIOT-OS#6018: nRF52 gnrc 6lowpan ble memory leak

other issues
------------
 RIOT-OS#1263: TLSF implementation contains (a) read-before-write error(s).
 RIOT-OS#3256: make: Setting constants on compile time doesn't really set them
       everywhere
 RIOT-OS#3366: periph/i2c: handle NACK
 RIOT-OS#4488: Making the newlib thread-safe: When calling puts/printf after
       thread_create(), the CPU hangs for DMA enabled uart drivers.
 RIOT-OS#4866: periph: GPIO drivers are not thread safe
 RIOT-OS#5128: make: buildtest breaks when exporting FEATURES_PROVIDED var
 RIOT-OS#5207: make: buildest fails with board dependent application Makefiles
 RIOT-OS#5390: pkg: OpenWSN does not compile: This package still uses deprecated
       modules and was not tested for a long time.
 RIOT-OS#5520: tests/periph_uart not working
 RIOT-OS#5561: C++11 extensions in header files
 RIOT-OS#5776: make: Predefining CFLAGS are parsed weirdly
 RIOT-OS#5863: OSX +  SAMR21-xpro: shell cannot handle command inputs larger than 64
       chars
 RIOT-OS#5962: Makefile: UNDEF variable is not working as documented
 RIOT-OS#6022: pkg: build order issue

Special Thanks
==============
We like to give our special thanks to all the companies that provided us with
their hardware for porting and testing, namely the people from (in
alphabeticalorder): Atmel, Freescale, Imagination Technologies, Limifrog,
Nordic, OpenMote, Phytec, SiLabs, UDOO,and Zolertia; and also companies that
directly sponsored development time: Cisco Systems, Eistec, Ell-i, Enigeering
Spirit, Nordic, FreshTemp LLC, OTAkeys and Phytec.

More information
================
http://www.riot-os.org

Mailing lists
-------------
* RIOT OS kernel developers list
  [email protected] (http://lists.riot-os.org/mailman/listinfo/devel)
* RIOT OS users list
  [email protected] (http://lists.riot-os.org/mailman/listinfo/users)
* RIOT commits
  [email protected] (http://lists.riot-os.org/mailman/listinfo/commits)
* Github notifications
  [email protected] (http://lists.riot-os.org/mailman/listinfo/notifications)

IRC
---
* Join the RIOT IRC channel at: irc.freenode.net, #riot-os

License
=======
* Most of the code developed by the RIOT community is licensed under the GNU
  Lesser General Public License (LGPL) version 2.1 as published by the Free
  Software Foundation.
* Some external sources are published under a separate, LGPL compatible
  license (e.g. some files developed by SICS).

All code files contain licensing information.
@PeterKietzmann PeterKietzmann modified the milestones: Release 2017.01, Release 2017.04 Jan 26, 2017
@kYc0o
Copy link
Contributor

kYc0o commented Apr 25, 2017

So, there was such workaround?

@jfbortolotti
Copy link
Contributor Author

Nothing cleaner than what described above so far.

@kYc0o
Copy link
Contributor

kYc0o commented Apr 26, 2017

What I mean is if a PR was opened with such workaround.

@jfbortolotti
Copy link
Contributor Author

No PR opened with such workaround.

@aabadie aabadie removed this from the Release 2017.04 milestone Jun 21, 2017
@kYc0o
Copy link
Contributor

kYc0o commented Jul 17, 2018

@pekkanikander your PR updating the softdevice would solve this issue?

@pekkanikander
Copy link
Contributor

@pekkanikander your PR updating the softdevice would solve this issue?

I don't know. I haven't had time to look at this bug.

@stale
Copy link

stale bot commented Aug 10, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions.

@stale stale bot added the State: stale State: The issue / PR has no activity for >185 days label Aug 10, 2019
@stale stale bot closed this as completed Sep 10, 2019
@aabadie aabadie reopened this Sep 21, 2019
@stale stale bot removed the State: stale State: The issue / PR has no activity for >185 days label Sep 21, 2019
@miri64
Copy link
Member

miri64 commented Sep 23, 2019

As nimble is now used per default with the NRF52dk instead of the soft device, shouldn't this be obsolete now?

@aabadie
Copy link
Contributor

aabadie commented Sep 23, 2019

As nimble is now used per default with the NRF52dk instead of the soft device, shouldn't this be obsolete now?

SoftDevice is still supported in RIOT so this is bug is still there. Maybe just update the PR title ? And try to apply the proposed fix ?

@miri64 miri64 changed the title nRF52 gnrc 6lowpan ble memory leak nRF52: gnrc_6lowpan_ble: memory leak with nordic_softdevice_ble Sep 23, 2019
@miri64
Copy link
Member

miri64 commented Sep 23, 2019

[…] And try to apply the proposed fix ?

Then please do, I don't believe there is anyone working with it right now though, due to several porting issues.

@Citrullin
Copy link
Contributor

Citrullin commented Feb 9, 2020

As nimble is now used per default with the NRF52dk instead of the soft device, shouldn't this be obsolete now?

SoftDevice is still supported in RIOT so this is bug is still there. Maybe just update the PR title ? And try to apply the proposed fix ?

I agree with @miri64. The package is not well maintained anymore, because NimBLE provides a better job and is the default package for nrf52 ble related things. We might even want to discuss removing the softdevice in the long run. Migration should be really simple due to the gnrc network stack.
Probably also a topic for @haukepetersen

@miri64
Copy link
Member

miri64 commented Jul 1, 2020

The softdevice is slated to be removed after 2020.10. If someone wants to fix that bug until then, it is very welcome, but for now I just assign the milestone as a memo for the next release manager (@bergzand).

@miri64 miri64 added this to the Release 2020.10 milestone Jul 1, 2020
@chrysn
Copy link
Member

chrysn commented May 10, 2021

With the removal of the softdevice complete, this has become moot; closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: BLE Area: Bluetooth Low Energy support Area: drivers Area: Device drivers Area: network Area: Networking Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

No branches or pull requests