gpio interrupt register fix

RIOT-OS · Jul 3, 2017 · 4bc42d5 · 4bc42d5
1 parent 2678d9e
commit 4bc42d5
Showing 1 changed file with 4 additions and 12 deletions.
diff --git a/cpu/cc2538/periph/gpio.c b/cpu/cc2538/periph/gpio.c
@@ -27,27 +27,19 @@
 #include "periph/gpio.h"
 
 #define GPIO_MASK           (0xfffff000)
-#define PORTNUM_MASK        (0x00003000)
+#define PORTNUM_MASK        (0x00007000)
 #define PORTNUM_SHIFT       (12U)
 #define PIN_MASK            (0x00000007)
 #define MODE_NOTSUP         (0xff)
 
 static inline cc2538_gpio_t *gpio(gpio_t pin)
 {
-    if(((uint32_t)pin &GPIO_MASK) == 0){
-        uint32_t port = (pin & 0x18) >> 3;
-        return (cc2538_gpio_t*)(((uint32_t)GPIO_A)+(port << PORTNUM_SHIFT));
-    }else{
-        return (cc2538_gpio_t *)(pin & GPIO_MASK);
-    }
+    return (cc2538_gpio_t *)(pin & GPIO_MASK);
 }
 
 static inline int port_num(gpio_t pin)
 {
-    if(((uint32_t)pin &GPIO_MASK) == 0){
-        return ((pin & 0x18) >> 3);
-    }
-    return (int)(((pin - (uint32_t)GPIO_A) & PORTNUM_MASK) >> PORTNUM_SHIFT);
+    return (int)((pin & PORTNUM_MASK) >> PORTNUM_SHIFT) - 1;
 }
 
 static inline int pin_num(gpio_t pin)
@@ -183,7 +175,7 @@ static inline void handle_isr(cc2538_gpio_t *gpio, int port_num)
 {
     uint32_t state       = gpio->MIS;
     gpio->IC             = 0x000000ff;
-    gpio->IRQ_DETECT_ACK = 0x000000ff;
+    gpio->IRQ_DETECT_ACK = (0xff << (port_num * GPIO_BITS_PER_PORT));
 
     for (int i = 0; i < GPIO_BITS_PER_PORT; i++) {
         if (state & (1 << i)) {