Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixup wrong comments / wrong cvar settings / wrong other things #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fixup wrong comments / wrong cvar settings / wrong other things #30

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c6f551
add ac / qol net cvar changes
Nov 28, 2020
21743bf
Update rgl_base.cfg
sapphonie Jun 19, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 10 additions & 13 deletions cfg/rgl_base.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,21 +42,20 @@ mp_tournament_stopwatch "1" // sets stopwatch mode if appli
mp_tournament_readymode "0" // traditional whole team ready up
mp_teams_unbalance_limit "0" // disables team balance checking

sv_mincmdrate "66" // sets the min value for cl_cmdrate to 66 ticks/sec
sv_maxcmdrate "66" // sets the max value for cl_cmdrate to 66 ticks/sec
sv_minrate "80000" // sets min acceptable client rate to 80000 packets/sec, tf2's default rate
sv_mincmdrate "30" // sets the min value for clients to send usercmds to the server to 30 per second
sv_maxcmdrate "66" // sets the max value for clients to send usercmds to the server to 66 per second
sv_minrate "65535" // sets min acceptable client rate to 65535 bytes/sec, a sane value below tf2's default rate but not by a huge margin
sv_maxrate "0" // sets max acceptable client rate to "unlimited", tho anything higher than 1048576 is ignored as it is tf2's "max" rate.
sv_minupdaterate "66" // sets min rate of requestable packets from server to client to 66 per sec
sv_maxupdaterate "66" // sets max rate of requestable packets from server to client to 66 per sec
sv_minupdaterate "30" // sets min rate of packets from server to client to 30 per sec
sv_maxupdaterate "66" // sets max rate of packets from server to client to 66 per sec
Comment on lines +45 to +50
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be slightly more lenient with net settings so as to not make people with crappy connections absolutely miserable. also fixup wrong comments

sv_client_min_interp_ratio "1" // clamps min client interp settings
sv_client_max_interp_ratio "2" // clamps max client interp settings
sv_client_cmdrate_difference "0" // clamps client cmdrate
sv_client_cmdrate_difference "0" // clamps client cmdrate to the same as client's updaterate, these should never not match each other unless you want huge client prediction issues
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

read the comment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you want to force this in code a la defensive programming and not just trusting valve it exists in stac

sv_client_predict "1" // forces cl_predict 1, essentially

// sv_clockcorrection_msecs "15" // attempts to better synchronize client's ticks closer to server's ticks. currently commented while i test possible hitreg issues
// ^ more info: https://github.com/VSES/SourceEngine2007/blob/master/se2007/game/server/player.cpp#L3036
// sm_cvar sv_maxusrcmdprocessticks_holdaim 2 // prevents pSilentAim from working (hopefully)
// sm_cvar tf_flamethrower_vecrand 0 // fixes random flamethrower velocity
Copy link
Contributor Author

@sapphonie sapphonie Jun 19, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these are wrong and useless.
sv_clockcorrection not being default seems to break random weapon Think() functions for some arcane reason, as well as bhopping
sv_maxusrcmdprocessticks_holdaim 2 doesn't fix anything, it just makes the server hold usercmds for an extra cmd for no reason
sv_maxusrcmdprocessticks_holdaim is a league decision. don't comment it, just readd it if rgl ever wants to.

sm_cvar sv_maxusrcmdprocessticks 8 // patch doubletap cheat and tighten up lag comp
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

8 reduces doubletap / fakelag abuse to basically nothing

sm_cvar sv_maxunlag 0.2 // limit fakelag abuse as well as prevent players with insanely high ping from having straight up advantage using hitscan
// ^ more info - https://github.com/sapphonie/StAC-tf2/blob/4f4a0f13ac81b3e03e93c80371067899b8fa37f3/scripting/stac.sp#L582-L585
// ^ which in turn used https://github.com/mastercomfig/team-comtress-2 as a base

mp_fadetoblack "0" // doesn't fade player's screen to black on death
mp_enableroundwaittime "1" // pauses server timer after winning a round
Expand All @@ -80,7 +79,6 @@ sv_gravity "800" // Sets gravity to default (800
sv_pure "2" // Sets sv_pure to 2. Don't touch this
sv_pure_kick_clients "1" // kick clients violating or attempting to violate sv_pure
sv_pure_trace "1" // sets the server to print a message whenever a client is verifying a CRC for a file
sv_pure_consensus "5" // minimum file hash checks for sv_pure
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sv pure doesn't hash files. the code for this is commented out. this cvar therefore does nothing


host_framerate "0" // unlocks server framerate, essentially

Expand Down Expand Up @@ -126,7 +124,6 @@ tv_transmitall "1" // transmits all entity data fr
// ^ THIS DOES NOT REPLACE SOURCETV+, which can be found here: https://github.com/dalegaard/srctvplus
tv_enable "1" // enables Source TV

sv_turbophysics "1" // prevents people from moving physics objects by shooting them or running into them when combined with disabling +use. results in less CPU usage on the server
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment is for if turbophysics is off, not on, also you don't want this off, it will break passtime maps and other maps with phys for no realistic performance gain

Copy link

@blakeplusplus blakeplusplus Nov 30, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't really understand why you're removing this line entirely? you don't want it off, so the line should stay, correct?
in addition to what sappho was saying about the comment, the valve dev wiki states that When sv_turbophysics is non-zero, players can't move physics objects by touch. To move them in turbophysics mode, they must press the use key. i've tested it and force from shooting the passtime ball with hitscan or projectiles does not change based on the value of sv_turbophysics. maybe this affects shooting other physics objects tho?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not shooting the ball, it was some strange issue where occasionally (not all the time) the passtime ball would be weird when you picked it up. i don't remember why i deleted it, i don't think there is a reason to delete it?

sv_alltalk "0" // sets alltalk off
sv_pausable "1" // enables the ability to pause
sv_allow_wait_command "0" // disables wait command
Expand Down