-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
migrate from Appveyor to GitHub Actions #338
Conversation
@fukatani Could you please give a second review for this PR? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Yes. Can you please point me to what was changed in the code base so that I can adjust the R code? Thanks for the notification. |
I think the only change in R-package was in Python version requirements: I don't think any code adjustments are needed because all R tests are passed in the latest If you think that requirements in Python version is too minor to have new release on CRAN, feel free to skip it. |
I think the drop of support for Python 2.7 (version) has to be added in the DESCRIPTION file of the CRAN package. I'll submit the updated version tomorrow to CRAN and I'll notify you once I received the approval. |
Hey @mlampros ! |
Hi, @StrikerRUS thanks for asking. I had indeed a bunch of problems when submitting the package: The problems were related with a namespace error as is also discussed in this issue and appeared mainly in the Windows version (I received 2 NOTES compared to the last submission of the package). It took me a while (I think 5 or 6 submissions) to figure out that it was related with the package.R file only and not with the tests, however it seems that it might be a good practice to not run the tests on CRAN . Finally, I ended up removing the initialization of Python from the .onload() function. Anyway, now it works for all operating systems, however CRAN included lately tests also for M1mac (Checks on a M1 (arm64) Mac). I think I fixed the error by adjusting a lot of code in the tests and examples section but currently it's not a requirement for a successful submission to CRAN (probably it's in a testing phase). I had to reply that I fixed the errors and now I'm awaiting for a response from the CRAN personnel. Once I receive the confirmation I'll make a pull request by uploading the new version. |
@mlampros Thank you very much for the detailed report!
Great! Thank you!
Yeah, I think this is beta test when CRAN picks up projects randomly and runs tests for them. For example, there is no
I remember you told that there are some problems with reticulate integration with scipy.sparse on macOS. Maybe it is enough just to adjust the following condition? rgf/R-package/tests/testthat/test-RGF_package.R Lines 303 to 308 in f740790
|
Kindly ping @fukatani for a new PyPI release. |
@fukatani CRAN release has been published recently: #340 (comment). Please help with PyPI one to sync packages (Python 3.9 support, removed Python 2.7 support, compatibility with new scikit-learn, etc.). |
@fukatani If you'd like, I can take the responsibility to make releases on PyPI. My nickname there is the same as on GitHub. |
@StrikerRUS I'm investigating how to transfer PyPI authority. |
Totally undestand!
No need to transfer, you can simply invite me to collaborate and I'll be able to upload new releases. Go to "Your projects" at PyPI site: https://pypi.org/manage/projects/. Click "Manage" button for the Select "Collaborators" tab at the left side of the page. Scroll down to the "Invite collaborator" section. My "Username" there is the same as at GitHub. |
@StrikerRUS |
@fukatani Thank you so so much! Just accented your invite. Will try to upload new release in a few days. |
New release is out! |
Fixed #122.
Appveyor suggests only 1 parallel job at free tier, GitHub Actions - 20.
Should be considered as a continuation of #328. Same changes as for *nix OSes: latest R version; stop producing 32bit artifacts.