New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

throw an error if encode input is not a buffer #18

Open

Kikobeats wants to merge 1 commit into RGBboy:master from Kikobeats:patch-3

Kikobeats commented Mar 24, 2021 •

edited

Loading

This prevents the user to wrongly provide a string, where the method .toString() doesn't accept any parameter.

> '+'.toString('base64')
'+'
> '+'.toString('hex')
'+'

so it's failing silently right now 😬


          throw an error if encode input is not a buffer

cc4ab53

md-ajju approved these changes

View reviewed changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet