Minor improvements #13
Conversation
|
Can you please explain what happens with the tx mining? Is it the case that a block can be mined but tx doesn't get there? |
With the current tests this never happens, everytime you mine a block the TX gets mined. But in the future with many more tests we could end up with blocks being full and therefore we could mine a block and not be sure the TX just broadcasted has been inserted in the mined block. So the commit 3f3c00a is not necessary now (and maybe will never be considered how many TXs can fit in a block) but since you were saying the non-deterministic behavior we discovered in #6 was due to the TX not always being mined I thought this change would make this part clearer and avoid developers having doubts like this in the future. |
No description provided.