Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

witness beneficiary not embedding close method #198

Closed
zoedberg opened this issue Apr 23, 2024 · 1 comment · Fixed by #203
Closed

witness beneficiary not embedding close method #198

zoedberg opened this issue Apr 23, 2024 · 1 comment · Fixed by #203
Assignees
@dr-orlovsky
Labels
bug Something isn't working
Milestone
v0.11.0

Comments

@zoedberg
Copy link
Contributor

During Viareggio meeting we reported that the WitnessVout beneficiary doesn't embed the desired close method. It was said that this is a bug because a receiver should be able to decide this. Currently it's up to the sender to decide which close method to use in that case.

@dr-orlovsky I think we should fix this before 0.11 preview release
@dr-orlovsky dr-orlovsky added this to the v0.11.0 milestone Apr 23, 2024
@dr-orlovsky dr-orlovsky moved this to Backlog in RGB release v0.11 Apr 23, 2024
@dr-orlovsky dr-orlovsky moved this from Backlog to Ready in RGB release v0.11 Apr 23, 2024
@dr-orlovsky dr-orlovsky self-assigned this Apr 23, 2024
@dr-orlovsky dr-orlovsky added the bug Something isn't working label Apr 23, 2024
@dr-orlovsky
Copy link
Member

Thank you for not forgetting!

dr-orlovsky added a commit that referenced this issue May 24, 2024
@dr-orlovsky
invoice: support custom close methods in vout-based invoices
88e00f1 
Closes #198
@dr-orlovsky dr-orlovsky mentioned this issue May 24, 2024
Merged
dr-orlovsky added a commit that referenced this issue May 24, 2024
@dr-orlovsky
invoice: support custom close methods in vout-based invoices
d45ce1c 
Closes #198
@dr-orlovsky dr-orlovsky moved this from Ready to In review in RGB release v0.11 May 25, 2024
@zoedberg zoedberg mentioned this issue Jun 7, 2024
Merged
dr-orlovsky added a commit that referenced this issue Jun 8, 2024
@dr-orlovsky
invoice: support custom close methods in vout-based invoices
c516df1 
Closes #198
@github-project-automation github-project-automation bot moved this from In review to Done in RGB release v0.11 Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dr-orlovsky dr-orlovsky

Labels
bug Something isn't working
Projects
RGB release v0.11
Status: Done
Milestone
v0.11.0
Development

Successfully merging a pull request may close this issue.

Support custom close methods in vout-based invoices RGB-WG/rgb-std
2 participants
@dr-orlovsky @zoedberg