This repository has been archived by the owner on Nov 15, 2022. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this PR adds 2 github workflows:
Bindings
ubuntu-latest
ubuntu-latest
macos-latest
Docker Build
Some considerations:
Unfortunately the
Docker Build
workflow fails forNo space left on device
. As specified by github docs free runners have14GB
of SSD disk space. Android bindings docker image weights15.1GB
. So, in order to merge this PR we can remove docker build workflow or use a self-hosted runner.As events triggering the
Bindings
workflow I've used:every pull request (no matter which files the PR changes)
every commit pushed on master (apart for those that just touch md files and demos)
Do you agree with this strategy or have you got some suggestions?
1.47.0
as a toolchain, maybestable
is better? We can also use a matrix of toolchains but maybe that gets us out of scope.