Skip to content
This repository has been archived by the owner on Nov 15, 2022. It is now read-only.

CI build #15

Merged
merged 2 commits into from
Nov 6, 2020
Merged

CI build #15

merged 2 commits into from
Nov 6, 2020

Conversation

zoedberg
Copy link
Contributor

@zoedberg zoedberg commented Nov 3, 2020

this PR adds 2 github workflows:

  • Bindings
    • builds android bindings on ubuntu-latest
    • builds node.js bindings on ubuntu-latest
    • builds iOS bindings on macos-latest
  • Docker Build
    • builds android bindings dockerization
    • builds node.js bindings dockerization

Some considerations:

  1. Unfortunately the Docker Build workflow fails for No space left on device. As specified by github docs free runners have 14GB of SSD disk space. Android bindings docker image weights 15.1GB. So, in order to merge this PR we can remove docker build workflow or use a self-hosted runner.

  2. As events triggering the Bindings workflow I've used:

  • every pull request (no matter which files the PR changes)

  • every commit pushed on master (apart for those that just touch md files and demos)

    Do you agree with this strategy or have you got some suggestions?

  1. I've used rust 1.47.0 as a toolchain, maybe stable is better? We can also use a matrix of toolchains but maybe that gets us out of scope.

@dr-orlovsky dr-orlovsky added the enhancement New feature or request label Nov 3, 2020
@dr-orlovsky dr-orlovsky added this to the v0.1 milestone Nov 3, 2020
@dr-orlovsky dr-orlovsky self-assigned this Nov 3, 2020
Copy link
Member

@dr-orlovsky dr-orlovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it ready for the merge or we need to do something else about it?

.github/workflows/bindings.yml Show resolved Hide resolved
.github/workflows/bindings.yml Show resolved Hide resolved
.github/workflows/bindings.yml Show resolved Hide resolved
.github/workflows/bindings.yml Show resolved Hide resolved
@dr-orlovsky
Copy link
Member

dr-orlovsky commented Nov 6, 2020

  1. Don't know what to do :(
  2. Let's leave it as is for now
  3. No idea... Stable is changing all the time, so fixed version is more "stable" (meaning it will build tomorrow if it had built yesterday). So let's have a specific version there

@dr-orlovsky dr-orlovsky merged commit 503291a into RGB-WG:master Nov 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants