This repository has been archived by the owner on Dec 9, 2023. It is now read-only.
process consignment: handle attachment assignments #212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please provide a bit more details why the existing code doesn't work? |
|
The existing code works well with |
|
Thank you. Now it all makes sense to me. I think we also need to support the remaining data types. I will merge this for now not to postpone this fix further and will open an issue. |
dr-orlovsky
approved these changes
Nov 15, 2022
| let mut assignment: Vec<Assignment<PedersenStrategy>> = | ||
| empty!(); | ||
|
|
||
| for out in outpoints.clone() { |
There was a problem hiding this comment.
It will be more efficient to remove clone here and put in in just a single branch which takes the ownership below (the other branch doesn't need to do the clone).
| let mut assignment: Vec<Assignment<AttachmentStrategy>> = | ||
| empty!(); | ||
|
|
||
| for out in outpoints.clone() { |
This was referenced Nov 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix is needed in order to support assignments of type
Assignment<AttachmentStrategy>