Fix a problem in SendCommand_SweepDataPointsEx and SaveFileCSV #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the "self." part of the function call in this class was missing.
CSV export methods were missing the last data point due to an indexing error.
|
The SaveFileCSV function was missing one datapoint due to an indexing error. |
TaeronKW
changed the title
This was manifesting as many FreqSpectrumSteps values being unusable due to the commands from SendCommand_SweepDataPoints() and SendCommand_SweepDataPointsEx() being encoded as 'utf-8' rather than 'latin-1' as the device seems to require. The hint for this solution came from observing that the messages coming back from the device are treated as 'latin-1' encoded when stored into the sNewText variable within ReceiveSerialThread.ReceiveThreadfunc() [on line 69].
|
Updated RFExplorer.SendCommand() to use 'latin_1' encoding as resolution to issue #31. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the "self." part of the function call in this class was missing.