Use SIGKILL to kill help server
#912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renkun-ken
changed the title
cp.kill to kill help serverSIGKILL to kill help server
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Closes #902
Closes #911
kill()fromtree-killpackage does not seem to work properly on Linux and macOS. I tested usingcp.kill()SIGKILLsignal and it works as expected on Windows, Linux and macOS.(If you do not have screenshot) How can I check this pull request?
watch -d 'ps aux | grep helpServer.R'The helpServer process should be properly killed on reload or exit. At most only one help server should appear at any time.