Making the vscode-r original coding conventions #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Ikuyadeu Interesting! How should we check this? |
|
Looks quite interesting and useful. Is there anything we should do to check? |
|
@andycraig @renkun-ken Thank you! After merging this, you can get the lint result on vscode by installing vscode-devreplay. |
Ikuyadeu
changed the title
|
@Ikuyadeu Great! I’m looking forward to trying it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem did you solve?
Related with #215 and microsoft/vscode#94751
I added my linter devreplay to verify the vscode-specific problems, such as #301
The deprecated functions are written on the
devreplay.json(If you have)Screenshot
I added bad syntax on the https://github.com/Ikuyadeu/vscode-R/compare/devreplay?expand=1#diff-f3fe9c4fe673e665c8df5914c3b9c9a0R333
After review, I will fix again that.
On the vscode:
On the GitHub Action: https://github.com/Ikuyadeu/vscode-R/pull/308/checks
@andycraig @renkun-ken Could you check this?