Bug fixes to RestfulDataProviderDbQuery #540
Conversation
|
Thanks @mohammed-nauage-gsa can you see why tests are failing? |
|
Fixed the tests. I am sorry about that. I had a hard time trying to setup testing locally. I am pretty new to php and drupal. Do things look ok now? |
| @@ -581,7 +554,7 @@ public function mapDbRowToPublicFields($row) { | |||
| } | |||
|
|
|||
| // Execute the process callbacks. | |||
| if ($value && $info['process_callbacks']) { | |||
| if ($info['process_callbacks']) { | |||
There was a problem hiding this comment.
maybe we should check !is_null()? I don't think we should process NULL values
|
I think its debatable, but I think that makes sense in most cases that I can imagine, so I updated it with isset since !is_null === isset. Also, I noticed viewMultiple doesn't ever seem to actually be used beyond how I used it in the this file. What do you think of removing it or should it stay to make sure a defined coding/naming pattern is kept? |
|
Are there any other issues that need to be resolved with this pull requests? |
|
@mohammed-nauage-gsa sorry for the delay. I have been working intensely in the |
Refactor view code to use viewMultiple so it can leverage some fixes that happened along the way in that method.
|
Merged. Thanks again! |
As the view function was not calling getQuery, it would not include properties from joins that someone may do. If changes were made, it would be exactly the same as viewMultiple other than one accepts arrays, so I just called viewMultiple.
As a value was required to be not falsy for process_callbacks to be called, it would not allow processing falsy values. For example, certain tables in Drupal appear to use "1" and "0" for true and false values. Someone may want to convert those "1" and "0" to true and false before returning the data, but "0" is falsy and process_callback could not be called.