Add watchdog entry if excpetion was thrown #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -527,6 +527,9 @@ function restful_menu_process_callback($resource_name, $version = NULL) { | |||
| foreach ($e->getHeaders() as $header_name => $header_value) { | |||
| drupal_add_http_header($header_name, $header_value); | |||
| } | |||
|
|
|||
| $severity = $e->getCode() < 500 ? WATCHDOG_NOTICE : WATCHDOG_ERROR; | |||
| watchdog('restful', $e->getMessage(), array(), $severity); | |||
There was a problem hiding this comment.
We should probably use watchdog_exception.
There was a problem hiding this comment.
Didn't know about watchdog_exception :) I think we should use it only for the below case and when status code >= 500.
amitaibu
changed the title
| @@ -527,6 +527,17 @@ function restful_menu_process_callback($resource_name, $version = NULL) { | |||
| foreach ($e->getHeaders() as $header_name => $header_value) { | |||
| drupal_add_http_header($header_name, $header_value); | |||
| } | |||
|
|
|||
| if ($e->getCode() < 500) { | |||
There was a problem hiding this comment.
What if we simplify this as:
// Even though it's an exception, it's in fact not a server error - it
// might be just access denied, or a bad request, so we just want to log
// it, but without marking it as an actual exception.
// If the code is 5XX then it is an actual server exception.
$severity = $e->getCode() < 500 ? WATCHDOG_NOTICE : WATCHDOG_ERROR;
watchdog_exception('restful', $e, NULL, array(), $severity);There was a problem hiding this comment.
the "problem" with watchdog_exception() is that it adds the line number where exception was thrown. However for exceptions < 500, we don't really need that info, since it's not really a server error, but just the way RESTful is taking advantage of exceptions to short circuit the flow.
e0ipso
added a commit
that referenced
this pull request
Jun 1, 2015
Add watchdog entry if excpetion was thrown
|
This was ported to 7.x-2.x in #726. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#521