Allow filtering column for a query with joins #397
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amitaibu
changed the title
amitaibu
changed the title
|
@mateu-aguilo-bosch ready for review |
|
actually I should probably add a node_access tag to the query. One sec... |
|
ready |
|
@mateu-aguilo-bosch ^^ |
|
Looks good! |
e0ipso
pushed a commit
to e0ipso/restful
that referenced
this pull request
Feb 1, 2015
|
Shit, this broke the tests. |
|
Weird, it was green. I'll try to have a look tomorrow. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
WHEREandORDER BYcan't use an alias column name, we must pass the explicit one. Tests and examples will follow.