fix: 🐛 fix flex driver #343
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Generate the script and create drivers then add drivers to shape key, fix the naming problem in script which case the fail of call driver, fix the nway function which is acctaully called in another way related REDxEYE#142 REDxEYE#341 REDxEYE#197
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate the script and create drivers then add drivers to shape key:
I put all the create driver founctions in one founction and call it before add shape key.
Fix the naming problem in script which cause the fail of call driver:
Example of value in driver function was like
Left_Smile = obj_data.flex_controllers["Smile"].value_left, butSmilewas used in return expression. I found only value withCloseLidwill have left and right in the front of name in return expression. So only keep right and left when there isLidin the name.Fix the nway function which is acctaully called in another way:
A real example
but the nway function didn't handle the tuple, so I added a function overloading.
may related #142 #341 #197
I'm not an expert in source module, I just tested some random hwm downloaded from workshop, maybe I'm not handling the module in a right way, but now the flex controller should work.