-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Docker development environment #31
Conversation
The Docker file looks good, with that #18 can be finished I think! I'm just wondering - bioconda is also creates a Docker image when building a new version of conda package. Can this maybe used instead? It's a general question, I'm a docker-noob. |
@xtrojak that is chicken and an egg problem -- if you use the biocontainer made from conda release, how do you test changes that you want to release? |
Right, I see. Yeah, that won't work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you had a look at the devcontainer system in vscode? Maybe we could make the remaining small additions in order to make this work!
This looks nice. I'll try to set it up and if it works push it here. |
The devcontainer is there and is working. |
The devcontainer doesn't work for me, it fails creating a temporary directory. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Both the container and testing in it work well. Minor comment inline. Thanks @maximskorik !
@hechth, could you try to build a devcontainer locally? Just so we make sure that the problem is related to the access rights on Abiff and not the devcontainer itself. |
@xtrojak can you try this as well please? It works locally, so I think it is some configuration problem on the other machine. |
As we found out, I was the only one with a write permission to this directory. Fixed now. |
dockerfile
with an image built upon Ubuntu 20.04 for reproducible testing