Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker development environment #31

Merged
merged 14 commits into from
Feb 18, 2022
Merged

Add Docker development environment #31

merged 14 commits into from
Feb 18, 2022

Conversation

maximskorik
Copy link
Member

@maximskorik maximskorik commented Feb 6, 2022

  • Added a dockerfile with an image built upon Ubuntu 20.04 for reproducible testing
  • Updated README with testing instructions
  • Added devcontainer to simplify dev environment setup in vscode

@maximskorik maximskorik linked an issue Feb 6, 2022 that may be closed by this pull request
@xtrojak
Copy link

xtrojak commented Feb 7, 2022

The Docker file looks good, with that #18 can be finished I think!

I'm just wondering - bioconda is also creates a Docker image when building a new version of conda package. Can this maybe used instead? It's a general question, I'm a docker-noob.

@martenson
Copy link
Member

@xtrojak that is chicken and an egg problem -- if you use the biocontainer made from conda release, how do you test changes that you want to release?

@xtrojak
Copy link

xtrojak commented Feb 7, 2022

@xtrojak that is chicken and an egg problem -- if you use the biocontainer made from conda release, how do you test changes that you want to release?

Right, I see. Yeah, that won't work.

Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you had a look at the devcontainer system in vscode? Maybe we could make the remaining small additions in order to make this work!

conda/environment-dev.yaml Outdated Show resolved Hide resolved
@maximskorik
Copy link
Member Author

Have you had a look at the devcontainer system in vscode? Maybe we could make the remaining small additions in order to make this work!

This looks nice. I'll try to set it up and if it works push it here.

@maximskorik maximskorik marked this pull request as draft February 8, 2022 09:22
@maximskorik
Copy link
Member Author

maximskorik commented Feb 8, 2022

The devcontainer is there and is working.

@maximskorik maximskorik marked this pull request as ready for review February 8, 2022 14:47
@maximskorik maximskorik marked this pull request as draft February 8, 2022 15:21
@maximskorik maximskorik marked this pull request as ready for review February 8, 2022 16:57
@hechth
Copy link
Member

hechth commented Feb 9, 2022

The devcontainer doesn't work for me, it fails creating a temporary directory.

Copy link
Member

@martenson martenson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the container and testing in it work well. Minor comment inline. Thanks @maximskorik !

@maximskorik
Copy link
Member Author

The devcontainer doesn't work for me, it fails creating a temporary directory.

@hechth, could you try to build a devcontainer locally? Just so we make sure that the problem is related to the access rights on Abiff and not the devcontainer itself.

@hechth
Copy link
Member

hechth commented Feb 18, 2022

@xtrojak can you try this as well please? It works locally, so I think it is some configuration problem on the other machine.

@maximskorik
Copy link
Member Author

The devcontainer doesn't work for me, it fails creating a temporary directory.

As we found out, I was the only one with a write permission to this directory. Fixed now.

@hechth hechth merged commit 00f9594 into master Feb 18, 2022
@martenson martenson deleted the testing branch February 18, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Irreproducible results on another machine
4 participants