Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactorings on combine.seq.3 and general adaptive.bin #196

Merged
merged 10 commits into from
Apr 19, 2023

Conversation

hechth
Copy link
Member

@hechth hechth commented Apr 14, 2023

Refactored the combine.seq.3 function to only use dplyr to summarize the data (as this is what it actually does) and generally renamed some variables in adaptive.bin and proc.cdf

@hechth hechth requested a review from xtrojak April 14, 2023 08:57
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: -0.53 ⚠️

Comparison is base (463e1cd) 66.65% compared to head (4911868) 66.13%.

❗ Current head 4911868 differs from pull request most recent head a555966. Consider uploading reports for the commit a555966 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #196      +/-   ##
==========================================
- Coverage   66.65%   66.13%   -0.53%     
==========================================
  Files          23       23              
  Lines        2624     2616       -8     
==========================================
- Hits         1749     1730      -19     
- Misses        875      886      +11     
Impacted Files Coverage Δ
R/compute_clusters.R 81.63% <ø> (ø)
R/adaptive.bin.R 100.00% <100.00%> (ø)
R/aggregate_by_rt.R 100.00% <100.00%> (ø)
R/recover.weaker.R 98.32% <100.00%> (ø)
R/remove_noise.R 58.33% <100.00%> (-22.92%) ⬇️
R/run_filter.R 100.00% <100.00%> (ø)
R/utils.R 90.12% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hechth hechth merged commit 387c165 into master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant