Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename proc.cdf to remove_noise #190

Merged
merged 6 commits into from
Apr 19, 2023
Merged

Conversation

xtrojak
Copy link

@xtrojak xtrojak commented Apr 3, 2023

Rename proc.cdf to remove_noise to better capture its functionality.

Close #79.

Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog, otherwise looks good!

CHANGELOG.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Apr 14, 2023

Codecov Report

Patch coverage: 75.00% and no project coverage change.

Comparison is base (cbe8bd3) 66.65% compared to head (60d8034) 66.65%.

❗ Current head 60d8034 differs from pull request most recent head 7657042. Consider uploading reports for the commit 7657042 to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #190   +/-   ##
=======================================
  Coverage   66.65%   66.65%           
=======================================
  Files          23       23           
  Lines        2624     2624           
=======================================
  Hits         1749     1749           
  Misses        875      875           
Impacted Files Coverage Δ
R/prof.to.features.R 87.19% <ø> (ø)
R/recover.weaker.R 98.32% <ø> (ø)
R/remove_noise.R 81.25% <ø> (ø)
R/semi.sup.R 0.00% <0.00%> (ø)
R/two.step.hybrid.R 0.57% <ø> (ø)
R/hybrid.R 100.00% <100.00%> (ø)
R/unsupervised.R 99.29% <100.00%> (ø)
R/utils.R 90.12% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@hechth hechth merged commit 463e1cd into RECETOX:master Apr 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename proc.cdf function as it is not exclusive to cdf format
2 participants