Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documented functions, removed unused variables & small refactoring of prof.to.features.R #170

Merged
merged 10 commits into from
Jan 5, 2023

Conversation

wverastegui
Copy link

@wverastegui wverastegui commented Dec 14, 2022

  • Documented functions, renamed one function name, removed unused variables & small refactoring of prof.to.features.R.
  • There is no issue created for this change.
  • Close Document compute_start_bound function #98

Copy link
Member

@maximskorik maximskorik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job annotating the individual steps with the comments! Unfortunately, I didn't comprehend that well the underlying logic of some steps when refactoring prof.to.features.

Copy link
Member

@hechth hechth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wverastegui great job documenting all functions and getting a proper understanding of whats going on!

@hechth hechth merged commit 6687181 into RECETOX:master Jan 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Document compute_start_bound function
3 participants