Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Returned tibble from adaptive.bin and proc.cdf #137

Merged
merged 16 commits into from
Aug 23, 2022
Merged

Returned tibble from adaptive.bin and proc.cdf #137

merged 16 commits into from
Aug 23, 2022

Conversation

hechth
Copy link
Member

@hechth hechth commented Aug 22, 2022 •
edited
Loading

  • Replaced return values of functions from lists of lists to tibbles with the respective tables.
  • Replaced retention time column names in adaptive.bin.R and recover.weaker.R with rt

Closes #114
Closes #136
Closes #139
Closes #138

zargham-ahmad
zargham-ahmad reviewed Aug 22, 2022
View reviewed changes
Copy link

@zargham-ahmad zargham-ahmad left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

R/adaptive.bin.R Outdated Show resolved Hide resolved
@hechth hechth merged commit b31f59d into RECETOX:master Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zargham-ahmad zargham-ahmad zargham-ahmad left review comments

@xtrojak xtrojak xtrojak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@hechth @xtrojak @zargham-ahmad