Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updatefallback page #95

Merged
merged 4 commits into from
May 3, 2022
Merged

Updatefallback page #95

merged 4 commits into from
May 3, 2022

Conversation

RDjarbeng
Copy link
Owner

Change message on fallback page to 'Oops, Check your connection & try again later'

@netlify
Copy link

netlify bot commented Apr 27, 2022 •
edited
Loading

✅ Deploy Preview for rcountdown ready!

Name Link
🔨 Latest commit 276b519
🔍 Latest deploy log https://app.netlify.com/sites/rcountdown/deploys/6271600e7fcbdd000821ebb4
😎 Deploy Preview https://deploy-preview-95--rcountdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@RDjarbeng RDjarbeng requested a review from nyakotey April 27, 2022 18:04
@RDjarbeng RDjarbeng added this to the Version 2 improvements milestone Apr 27, 2022
nyakotey
nyakotey requested changes Apr 28, 2022
View reviewed changes
Copy link
Collaborator

@nyakotey nyakotey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unpush gitignore file
update the cache version

@RDjarbeng RDjarbeng requested a review from nyakotey April 30, 2022 12:34
nyakotey
nyakotey approved these changes May 1, 2022
View reviewed changes
Copy link
Collaborator

@nyakotey nyakotey left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved
resolve conflict, change all links e.g. ../ on the fallback page to root relative / so that it is consistent with the rest of the site

@RDjarbeng RDjarbeng merged commit 49389d7 into master May 3, 2022
@RDjarbeng RDjarbeng deleted the updatefallback branch May 3, 2022 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nyakotey nyakotey nyakotey approved these changes

Assignees
No one assigned
Labels
ui / ux
Projects
None yet
Milestone
Version 2 improvements
Development

Successfully merging this pull request may close these issues.
2 participants
@RDjarbeng @nyakotey