Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

form popups to follow dark mode #92

Merged
merged 7 commits into from
Apr 27, 2022
Merged

form popups to follow dark mode #92

merged 7 commits into from
Apr 27, 2022

Conversation

nyakotey
Copy link
Collaborator

dark mode now applies to form popups as well

@nyakotey nyakotey requested a review from RDjarbeng April 24, 2022 14:33
@netlify
Copy link

netlify bot commented Apr 24, 2022 •
edited
Loading

✅ Deploy Preview for rcountdown ready!

Name Link
🔨 Latest commit 0c4f257
🔍 Latest deploy log https://app.netlify.com/sites/rcountdown/deploys/62695a0e0006260008a91b4f
😎 Deploy Preview https://deploy-preview-92--rcountdown.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@nyakotey
Merge branch 'master' into formdark
8e7cc94
@nyakotey
fixes
28695b4 
fix dark mode not applying on forms on about page
(cause: theme not explicitly set)
fix different default mode on different pages
(set default to light)
RDjarbeng
RDjarbeng approved these changes Apr 27, 2022
View reviewed changes
Copy link
Owner

@RDjarbeng RDjarbeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with condition of already discussed changes☑️

@RDjarbeng
Copy link
Owner

You may activate service worker

@nyakotey nyakotey merged commit affd800 into master Apr 27, 2022
@nyakotey nyakotey deleted the formdark branch April 27, 2022 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RDjarbeng RDjarbeng RDjarbeng approved these changes

Assignees
No one assigned
Labels
ui / ux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyakotey @RDjarbeng