Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

v2.4.1 version update #114

Merged
merged 2 commits into from
May 26, 2022
Merged

v2.4.1 version update #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8744921
add version update to readme and about page
nyakotey May 26, 2022
35e5694
activate sw
nyakotey May 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions app.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,14 +298,14 @@ addWhatappEventHandler();

// service worker

// if('serviceWorker' in navigator){
// window.addEventListener('load', () => {
// navigator.serviceWorker.register('/sw.js')
// .then( (reg)=>{
// console.log('service worker registered', reg)
// })
// .catch((err)=> console.log('Service worker not registered', err));
// });
if('serviceWorker' in navigator){
window.addEventListener('load', () => {
navigator.serviceWorker.register('/sw.js')
.then( (reg)=>{
console.log('service worker registered', reg)
})
.catch((err)=> console.log('Service worker not registered', err));
});

// }
}

4 changes: 4 additions & 0 deletions docs/dev-process.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,6 +154,10 @@ Not all elements made it into the final product, some others also got modified,
![v2 4@0,5x](https://user-images.githubusercontent.com/73431750/170242064-43aa6765-229c-43e8-a6e7-ed39e7de3ee0.png)


## Countdown v2.4.1
* fix sidebar option text going under the icon


### Potential and/or current developments
* listpage as the homepage with onboarding
* ui for elapsed countdown and clickless countdown updating
Expand Down
2 changes: 1 addition & 1 deletion html/about.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@
</div>
<div class="details">
<div class="details-title">Version</div>
<div class="details-info">2.4.0</div>
<div class="details-info">2.4.1</div>
</div>
<div class="details">
<div class="details-title">Credits</div>
Expand Down
4 changes: 4 additions & 0 deletions readme.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,10 @@ Added contributor [Nathaniel Nyakotey](https://github.com/nyakotey)
![v2 4@0,5x](https://user-images.githubusercontent.com/73431750/170242064-43aa6765-229c-43e8-a6e7-ed39e7de3ee0.png)


## Countdown v2.4.1
* fix sidebar option text going under the icon


---
#### Many more to come, stay tuned!
For more details, and live updates, checkout the [dev process](/docs/dev-process.md) readme
4 changes: 2 additions & 2 deletions sw.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
// #5

const staticCacheName = 'site-static-v54';
const dynamicCache = 'site-dynamic-v54';
const staticCacheName = 'site-static-v55';
const dynamicCache = 'site-dynamic-v55';

const dynamicCacheSize = 30;

Expand Down