-
Notifications
You must be signed in to change notification settings - Fork 124
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve packaging #196
Improve packaging #196
Conversation
@@ -21,7 +21,7 @@ Then you have to [create a release](https://github.com/blog/1547-release-your-so | |||
|
|||
And then upload the release to pypi: | |||
|
|||
python setup.py register sdist --formats=gztar,zip bdist_egg upload | |||
python setup.py sdist && twine upload dist/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should be uploading wheels also, but fine as is as it already improves on previous commands.
some packages have to be installed before. So please install the packages | ||
listed in requirements.development.txt: | ||
``pip install -r requirements.development.txt`` | ||
- ``test``: some unit and integrations tests. In order to run the tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm fairly sure this is deprecated:
- setup.py test is going to be deprecated pytest-dev/pytest#5534
- https://docs.pytest.org/en/latest/explanation/goodpractices.html#integrating-with-setuptools-python-setup-py-test-pytest-runner
Integration with setuptools is not recommended, i.e. you should not be using python setup.py test or pytest-runner, and may stop working in the future.
Maybe it is okay for now, but better to point people to tox if they want something easy to manage.
I'm somewhat okay with the change you made as is, because it makes it no worse, but this is something we have to fix sometime.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good, I'm a bit on the fence on removing the requirements.txt files, but I can't really see a good case for keeping them. I'm open to hearing other opinions, worse case scenario we can add them back but I think it is best to not use requirements.txt to populate the dependencies so either way your change to setuptools keywords (now in setup.cfg
) is for the better.
reverted deletion of requirements.txt. |
I introduce useful packaging way to use
setup.cfg
,setup.py
, andpyproject.toml
.It will be able to use both
pip install .
andpip install -e .
, and also write almost configurations of tools insetup.cfg
.When you want to install dev dependencies, you can do it by running
pip install .[dev]
.