-
Notifications
You must be signed in to change notification settings - Fork 99
Revive build.properties, remove byte order mark #353
Conversation
With these changes I see the following Scalariform parser errors for the
|
These changes have also broken existing functionality:
|
Thanks for catching this, I'll try to fix it. |
Thank you! Regarding the Scalariform parser errors, I think this is a pure sbt version issue, has nothing to do with Eventuate's |
The |
112c61e
to
c859803
Compare
The BOM was introduced with commit 2e97ed2. Since then the sbt version in `build.properties` was ignored (by the sbt launcher), in consequence the sbt launcher's sbt version was used. If the sbt launcher was now updated to 0.13.13, the warnings described in RBMHTechnology#351 popped up. Resolves RBMHTechnology#351
c859803
to
90a84d4
Compare
Thanks for the update @magro. The version in
However, I still see the Scalariform parser errors. |
Haven't looked at the scalariform stuff, how is this related to this PR? This PR now only intends to fix build.properties, I'd suggest to open another issue for scalariform. |
It's related to this PR as the Scalariform parser errors do not appear in earlier sbt versions. Anyway, opening another ticket for that is fine. Thanks for the PR, Martin! |
You're welcome :-) If time permits I can have a look at #356. |
The BOM was introduced with commit 2e97ed2. Since then the sbt version in
build.properties
was ignored (by the sbt launcher), in consequence the sbt launcher's sbt version was used.If the sbt launcher was now updated to 0.13.13, the warnings described in #351 popped up.