This repository has been archived by the owner on Jun 1, 2021. It is now read-only.
Wip 286 disaster recovery enhancements #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| val filter = sourceConnector.connection.filters.get(target.logName) match { | ||
| case Some(f) => f | ||
| case None => NoFilter | ||
| if (sourceLogIds.forall(_.contains(source.logId))) { |
There was a problem hiding this comment.
Why not having a replicationLinks: Set[ReplicationLink] parameter instead if callers want to control which replicators should be set up? All callers have access to the SourceConnector.links method to obtain the links they need.
There was a problem hiding this comment.
But they do not have access to the ReplicationEndpointInfo that they have to provide to the links methods, right? In particular ReplicationEndpoint.activate does not have access to an ReplicationEndpointInfo, but even in Acceptor.recovering the links might be across several endpoints. Or am I missing something?
|
LGTM |
volkerstampa
force-pushed
the
wip-286-disaster-recovery-enhancements
branch
3 times, most recently
from
fc34251 to
40f7128
Compare
- use dedicated message for resetting remote replication progress - replace println progress logging by using akka-log - add tests for - recovery after upgrade - simultaneous recovery - start event recovery from filtered connections *after* event recovery from unfiltered connections is finished - test recovery over filtered/unfiltered connections - adjust local sequence nr when receiving replicated events - remove sequence no gap detection as there might be gaps in case of incomplete disaster recovery - closes #286
volkerstampa
force-pushed
the
wip-286-disaster-recovery-enhancements
branch
from
40f7128 to
0edb9e7
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.