Configuration bug #552
Merged
Configuration bug #552
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bdegraaf1234
force-pushed
the
bugfix-pathconfig
branch
from
34793d8
to
02f9545
Compare
|
in 6814c16 You can see a log message which indicates that the two levels of configuration are the same for the unittest added in this pull request (recordPathFactoryTest.kt, as well as the other unit tests that I checked) but NOT for the integration test.
|
Bdegraaf1234
force-pushed
the
bugfix-pathconfig
branch
4 times, most recently
from
0144ab4
to
ae98a17
Compare
Bdegraaf1234
force-pushed
the
bugfix-pathconfig
branch
from
2758139
to
dceae12
Compare
thehyve-radar-vulnerability-scanning
approved these changes
Apr 2, 2024
Bdegraaf1234
force-pushed
the
bugfix-pathconfig
branch
from
dceae12
to
cbf509b
Compare
|
@pvannierop and I looked more closely at this and found the issue was located in the PathConfig.createFactory() method, which in its current implementation could not pass any configuration to the created factory.path property. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is to fix an apparent bug (#551) in the output restructure configuration process.
I added a test but cannot capture the problem in a proper unit test so added an integration test.