Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organization bucket #549

Draft
wants to merge 10 commits into
base: dev
Choose a base branch
from
Draft

Organization bucket #549

wants to merge 10 commits into from

Conversation

blootsvoets
Copy link
Member

@blootsvoets blootsvoets commented Oct 24, 2023

Proper support for multi-bucket setups.

Current implementation has a default format with

paths:
  target:
     format: null
     default: radar-output-storage

but this can be changed to for example

paths:
  target:
     format: radar-output-${mp:organization}
     default: radar-output-storage
     plugins: mp
     properties:
         managementPortalUrl: http://localhost:8080/managementportal

Then for each organization that has a separate bucket, a new target needs to be created:

targets:
   radar-output-storage:
      type: s3
      path: output
      s3: ...
   radar-output-staging:
      type: s3
      path: /
      s3: ...

The above will output all data to radar-output-storage, except data generated as part of the staging organization which is output to radar-output-staging. The paths.inputs and paths.output have been deprecated in favour of specifying the input and output paths as part of the source and target storage.

TODO:

  • add migration docs
  • test on server
  • test with azure

Fixes #65.

Copy link
Member

@Bdegraaf1234 Bdegraaf1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I am assuming the WIP is the TODO list? You want one of us to pick this up?

@blootsvoets
Copy link
Member Author

I am assuming the WIP is the TODO list? You want one of us to pick this up?

Indeed. That would be good, yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants