-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organization bucket #549
Draft
blootsvoets
wants to merge
10
commits into
dev
Choose a base branch
from
organization-bucket
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Organization bucket #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blootsvoets
requested review from
yatharthranjan,
peyman-mohtashami,
mpgxvii and
Bdegraaf1234
October 24, 2023 15:24
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
I am assuming the WIP is the TODO list? You want one of us to pick this up?
src/main/java/org/radarbase/output/source/SourceStorageFactory.kt
Outdated
Show resolved
Hide resolved
blootsvoets
force-pushed
the
organization-bucket
branch
from
October 25, 2023 11:37
8c088ee
to
b9e05c1
Compare
Indeed. That would be good, yes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proper support for multi-bucket setups.
Current implementation has a default format with
but this can be changed to for example
Then for each organization that has a separate bucket, a new target needs to be created:
The above will output all data to
radar-output-storage
, except data generated as part of the staging organization which is output toradar-output-staging
. Thepaths.inputs
andpaths.output
have been deprecated in favour of specifying the input and output paths as part of the source and target storage.TODO:
Fixes #65.