Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new events to Phone Usage Manager. #431

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

this-Aditya
Copy link
Member

Fixes #430

@Hsankesara
Copy link
Member

Hsankesara commented Aug 2, 2023

I am not sure if we should create new events or we could just label the rest of the events as Foreground, background or Interaction.


            FOREGROUND_SERVICE_START -> UsageEventType.FOREGROUND
            FOREGROUND_SERVICE_STOP -> UsageEventType.BACKGROUND
            STANDBY_BUCKET_CHANGED -> ?
            ACTIVITY_STOPPED -> UsageEventType.BACKGROUND

what do you think @yatharthranjan @blootsvoets ?

@blootsvoets
Copy link
Member

I am not sure if we should create new events or we could just label the rest of the events as Foreground, background or Interaction

New event types are probably better. Foreground service means that there is something happening in the background that the user could be aware of via a notification. But no window or interaction is present. So that is why it was previously mapped to OTHER, we saw no big benefit in explicitly mapping it. But it's fine to do so anyway. Once the schema is merged, I'm fine with accepting this change.

@this-Aditya this-Aditya deleted the usage-events-update branch May 10, 2024 03:51
@this-Aditya this-Aditya restored the usage-events-update branch May 10, 2024 03:52
@this-Aditya this-Aditya reopened this May 10, 2024
@this-Aditya
Copy link
Member Author

Sorry, I accidentally deleted it. I was deleting the branch locally, and the PR was automatically closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants