feat: add support for q:base
#93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM but, I had a good next proposal for multiple bases in a single app. IE, multiple qwik apps. Like the idea of I could even propose to make it: |
| url?: URL | ||
| element: Element | null, | ||
| eventUrl?: string | null, | ||
| _url?: string, |
There was a problem hiding this comment.
Not important, but why the _ here?
There was a problem hiding this comment.
because it is cut and paste from a bootloader where they are parameters to save bytes and I wanted to make it clear that they are not to be used.
| doc.baseURI | ||
| ); | ||
| url.pathname += '.js'; | ||
| if (eventUrl === undefined) { |
There was a problem hiding this comment.
if (eventUrl) won't do, can we use if (eventUrl == null)?
There was a problem hiding this comment.
NO, it specifically is looking for undefined
| @@ -35,9 +33,9 @@ export function qImport<T>(node: Node | Document, url: string | QRL<T> | URL): T | |||
| return Promise.resolve<T>(testSymbol); | |||
| } | |||
| } | |||
| const doc: QDocument = node.ownerDocument || (node as Document); | |||
| const doc: QDocument = element.ownerDocument!; | |||
There was a problem hiding this comment.
Not possible for document to be an element?
adamdbradley
approved these changes
Nov 30, 2021
adamdbradley
pushed a commit
to adamdbradley/qwik
that referenced
this pull request
Dec 13, 2021
* feat: add support for `q:base` * fixup! feat: add support for `q:base` Co-authored-by: Misko Hevery <>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.