Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Fix prevUrl on first render #7082

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

damianpumar
Copy link

What is it?

Description

The first time you load a route, prevUrl should be undefined

Screen.Recording.2024-11-21.at.19.49.18.mov

Checklist

  • My code follows the developer guidelines of this project
  • I performed a self-review of my own code
  • I added a changeset with pnpm change
  • I made corresponding changes to the Qwik docs
  • I added new tests to cover the fix / functionality

@damianpumar damianpumar requested a review from a team as a code owner November 21, 2024 18:54
Copy link

changeset-bot bot commented Nov 21, 2024

⚠️ No Changeset found

Latest commit: 5f42e75

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your help @damianpumar
Can you add the change set please?
Here is the tutorial

Copy link

pkg-pr-new bot commented Nov 21, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@7082
npm i https://pkg.pr.new/@builder.io/qwik-city@7082
npm i https://pkg.pr.new/eslint-plugin-qwik@7082
npm i https://pkg.pr.new/create-qwik@7082

commit: b5a0660

Copy link
Contributor

github-actions bot commented Nov 21, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview b5a0660

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐞] prevUrl of the useLocation() is set even if the first view.
2 participants