fix(dev): let vite do all dev url handling #7037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we now take the verbatim parent url to build the qrls, and let vite decode it. This makes it work in windows and with the different relative/absolute urls that vite generates.
🦋 Changeset detectedLatest commit: 546d3b0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
wmertens
force-pushed
the
fix-dev
branch
2 times, most recently
from
96afe2e
to
907eaa7
Compare
commit: |
wmertens
force-pushed
the
fix-dev
branch
2 times, most recently
from
b34057f
to
a9a9c96
Compare
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
shairez
approved these changes
Nov 4, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we now take the verbatim parent url to build the qrls, and let vite decode it.
This makes it work in windows and with the different relative/absolute urls that vite generates.