Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

6799 fix route #6970

Merged
merged 15 commits into from
Nov 4, 2024
Merged

6799 fix route #6970

merged 15 commits into from
Nov 4, 2024

Conversation

JerryWu1234
Copy link
Contributor

@JerryWu1234 JerryWu1234 commented Oct 12, 2024

#6799

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

this error because is routeToPush will be added more than one when paths didn't be found. also when paths is empty

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@JerryWu1234 JerryWu1234 requested a review from a team as a code owner October 12, 2024 03:27
Copy link

changeset-bot bot commented Oct 12, 2024

🦋 Changeset detected

Latest commit: 4919bdb

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 12, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6970
npm i https://pkg.pr.new/@builder.io/qwik-city@6970
npm i https://pkg.pr.new/eslint-plugin-qwik@6970
npm i https://pkg.pr.new/create-qwik@6970

commit: 4919bdb

Copy link
Contributor

github-actions bot commented Oct 12, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 4919bdb

.changeset/twenty-radios-camp.md Outdated Show resolved Hide resolved
.changeset/twenty-radios-camp.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens merged commit da725e9 into QwikDev:main Nov 4, 2024
19 checks passed
@github-actions github-actions bot mentioned this pull request Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants