-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix action redirect searchParam regression #6927
Conversation
🦋 Changeset detectedLatest commit: 784ef56 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
@wmertens Know who I should ask to look at this? It’s already going stale. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good except for the two cosmetic changes
I guess this is all good now? Need this for an upgrade to 1.9.x at work. Also excited to try the |
Yes, as soon as @wmertens marks their review as approved it will be merged into main 🙌 |
@brandonpittman thanks! Yes I tried to quickly get it merged yesterday but I missed the window, so it will go out in 1.9.2. I don't think we'll wait long for that. |
What is it?
Description
#6778 introduced a regression where redirects to URLs without any searchParams were getting searchParams appended. This PR restore the original behavior while still keeping the regression-introducing PR's intent.
Checklist:
pnpm change
and documented my changes