Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix action redirect searchParam regression #6927

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

brandonpittman
Copy link
Contributor

@brandonpittman brandonpittman commented Oct 2, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

#6778 introduced a regression where redirects to URLs without any searchParams were getting searchParams appended. This PR restore the original behavior while still keeping the regression-introducing PR's intent.

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • Added new test routes to cover the fix / functionality

Copy link

changeset-bot bot commented Oct 2, 2024

🦋 Changeset detected

Latest commit: 784ef56

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Oct 2, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6927
npm i https://pkg.pr.new/@builder.io/qwik-city@6927
npm i https://pkg.pr.new/eslint-plugin-qwik@6927
npm i https://pkg.pr.new/create-qwik@6927

commit: 784ef56

Copy link
Contributor

github-actions bot commented Oct 2, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 784ef56

@brandonpittman
Copy link
Contributor Author

Closes #6926 by fixing regression created in #6778.

@brandonpittman brandonpittman marked this pull request as ready for review October 2, 2024 03:32
@brandonpittman brandonpittman requested review from a team as code owners October 2, 2024 03:32
@brandonpittman
Copy link
Contributor Author

@wmertens Know who I should ask to look at this? It’s already going stale.

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good except for the two cosmetic changes

packages/qwik/src/optimizer/src/qwik-binding-map.ts Outdated Show resolved Hide resolved
packages/docs/src/routes/api/qwik/api.json Outdated Show resolved Hide resolved
@wmertens wmertens enabled auto-merge (squash) October 6, 2024 18:26
@brandonpittman
Copy link
Contributor Author

I guess this is all good now? Need this for an upgrade to 1.9.x at work. Also excited to try the noSpa option in the config!

@ianlet
Copy link
Contributor

ianlet commented Oct 7, 2024

I guess this is all good now? Need this for an upgrade to 1.9.x at work. Also excited to try the noSpa option in the config!

Yes, as soon as @wmertens marks their review as approved it will be merged into main 🙌

@wmertens wmertens merged commit dfefcb7 into QwikDev:main Oct 7, 2024
19 checks passed
@wmertens
Copy link
Member

wmertens commented Oct 7, 2024

@brandonpittman thanks! Yes I tried to quickly get it merged yesterday but I missed the window, so it will go out in 1.9.2. I don't think we'll wait long for that.

@github-actions github-actions bot mentioned this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants