docs: fix useResource example & remove unused demo #6893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 278695a The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
ianlet
force-pushed
the
docs-fix-useresource
branch
2 times, most recently
from
32556f5
to
987d6b9
Compare
* Replace github API call with a free fake & reliable API * Wrap API call in try/catch to prevent future error 500
shairez
approved these changes
Oct 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Fixes https://github.com/orgs/QwikDev/projects/1/views/2?pane=issue&itemId=72272653
The previous
useResourceexample was using the github api, which might get rate limited. Instead, the example now uses a free fake and stable API. Potential errors are also caught in order to avoid other issues.In addition, this PR deletes the unused demo
demo/tasks/resourceNote: the error mentioned in the issue doesn't actually happen in local. So this is a bit of a wild guess as to why it might fail in production.
Checklist:
pnpm changeand documented my changes