Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add .ico to isStaticPath to prevent large 404 responses #6860

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

intellix
Copy link
Contributor

@intellix intellix commented Sep 4, 2024

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests / types / typos
  • Infra

Description

When viewing any file in Chrome I noticed that it always makes a request for favicon.ico and saw that it was a 255kb pretty 404 page. I think it makes sense to include .ico as a file to regard as static.

Screenshot 2024-09-04 at 16 05 23

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have ran pnpm change and documented my changes
  • I have made corresponding changes to the Qwik docs
  • Added new tests to cover the fix / functionality

@intellix intellix requested a review from a team as a code owner September 4, 2024 14:03
Copy link

changeset-bot bot commented Sep 4, 2024

🦋 Changeset detected

Latest commit: 5538e84

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@builder.io/qwik-city Patch
eslint-plugin-qwik Patch
@builder.io/qwik Patch
create-qwik Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

pkg-pr-new bot commented Sep 4, 2024

Open in Stackblitz

npm i https://pkg.pr.new/@builder.io/qwik@6860
npm i https://pkg.pr.new/@builder.io/qwik-city@6860
npm i https://pkg.pr.new/eslint-plugin-qwik@6860
npm i https://pkg.pr.new/create-qwik@6860

commit: 0f8304d

@intellix
Copy link
Contributor Author

intellix commented Sep 4, 2024

Tried to use pnpm change, but no matter what I do it says no items selected etc

Screenshot 2024-09-04 at 15 14 18

Edit: ok I needed to press space to select them

Copy link
Contributor

github-actions bot commented Sep 4, 2024

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
qwik-docs ✅ Ready (View Log) Visit Preview 0f8304d

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems ok to me but please fix the changeset

.changeset/pink-ravens-exist.md Outdated Show resolved Hide resolved
@shairez
Copy link
Contributor

shairez commented Sep 9, 2024

Thanks @intellix

Here's a tutorial I recorded about changesets -
https://go.screenpal.com/watch/cZivIcVPJQV

hope it'll make things easier

@intellix
Copy link
Contributor Author

intellix commented Sep 9, 2024

cheers, I've fixed it. Originally I couldn't figure out how to use it cause I didn't know you had to press space bar until watching your video before. I guess I just pressed space on the next one without realising it was talking about major/minor

Copy link
Member

@wmertens wmertens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wmertens wmertens enabled auto-merge (squash) September 9, 2024 19:40
@wmertens
Copy link
Member

wmertens commented Sep 9, 2024

@intellix you still marked it minor instead of patch. Anyway I edited it, no problem, just remember for next time.

@wmertens wmertens merged commit 902b041 into QwikDev:main Sep 9, 2024
13 checks passed
@intellix intellix deleted the is-static-path-ico branch September 10, 2024 03:22
@github-actions github-actions bot mentioned this pull request Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants