-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add .ico to isStaticPath to prevent large 404 responses #6860
Conversation
🦋 Changeset detectedLatest commit: 5538e84 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
0c9ad50
to
ff2c90e
Compare
commit: |
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
ff2c90e
to
936eb89
Compare
936eb89
to
0cd038c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems ok to me but please fix the changeset
Thanks @intellix Here's a tutorial I recorded about changesets - hope it'll make things easier |
0cd038c
to
0f8304d
Compare
cheers, I've fixed it. Originally I couldn't figure out how to use it cause I didn't know you had to press space bar until watching your video before. I guess I just pressed space on the next one without realising it was talking about major/minor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@intellix you still marked it minor instead of patch. Anyway I edited it, no problem, just remember for next time. |
What is it?
Description
When viewing any file in Chrome I noticed that it always makes a request for favicon.ico and saw that it was a 255kb pretty 404 page. I think it makes sense to include .ico as a file to regard as static.
Checklist:
pnpm change
and documented my changes