fix(server-functions): omitted any from fieldErrors #6720

tzdesign · 2024-07-24T11:14:08Z

Typescript crashes because any could be infinite

fix #6719

What is it?

Feature / enhancement
Bug
Docs / tests / types / typos

Description

See

[🐞] fieldErrors - Type instantiation is excessively deep and possibly infinite. #6719

Checklist:

My code follows the developer guidelines of this project
I have performed a self-review of my own code
I have made corresponding changes to the documentation
Added new tests to cover the fix / functionality

Typescript crashes because any could be infinite fix QwikDev#6719

changeset-bot · 2024-07-24T11:14:11Z

⚠️ No Changeset found

Latest commit: 8d39078

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify · 2024-07-24T11:14:11Z

‼️ Deploy request for qwik-insights rejected.

Name	Link
🔨 Latest commit	`271baaf`

tzdesign · 2024-07-24T11:21:14Z

@gioboa @shairez Looks like I've tripped myself up. We sometimes use any because we have multi-step forms. Typescript unfortunately can't handle it. Showing: Type instantiation is excessively deep and possibly infinite.

I rewrote it so that the type never ends up in fieldErrors because Zod ignores any anyway.

I hope one of you can write typescript a little better than I can. I have patched it with the small change to
{} extends T[K] which excludes all any types. Let's see if it still works like this in later Typescript versions.

pkg-pr-new · 2024-07-24T11:28:29Z

commit: 0e16913

npm i https://pkg.pr.new/@builder.io/qwik@6720

npm i https://pkg.pr.new/@builder.io/qwik-city@6720

npm i https://pkg.pr.new/eslint-plugin-qwik@6720

npm i https://pkg.pr.new/create-qwik@6720

Open in Stackblitz •

starters/apps/qwikcity-test/src/routes/(common)/actions/issue5463/index.tsx

packages/qwik-city/runtime/src/types.ts

tzdesign · 2024-08-02T07:57:04Z

@fabian-hiller just to let you know the ValidatorErrorKeyDotNotation wasn't capturing Record types. Added IsAny to the types.ts in the runtime and added tests.

Maybe you can catch up with me some time talking about rewriting this a bit more.
There are still edge-cases for arrays in my concept, but it's better than having the top-level keys with flatten rod errors.

fabian-hiller · 2024-08-02T08:45:07Z

Have you seen my PR #6752?

wmertens

wmertens · 2024-08-02T09:20:30Z

@fabian-hiller I'd like to merge this already, it will cause your pr to get merge conflicts though. Ok?

fabian-hiller · 2024-08-02T09:37:01Z

packages/qwik-city/src/runtime/src/types.ts

-          : `${Prefix}${K}`;
-    }[keyof T & string]
-  : never;
+export type IsAny<T> = 0 extends T & 1 ? true : false;


I think the IsAny type is just a internal util type similar to the Prettify type above and should not be exported.

fabian-hiller · 2024-08-02T09:40:25Z

@wmertens and @tzdesign, this PR contains the same any fix as #6752. To avoid merge conflicts, it might be easier to just move the server-functions.unit.ts file to my PR and add Tobi as a co-author.

tzdesign · 2024-08-02T09:55:54Z

@fabian-hiller I'm fine with it, but I copied your type and your type includes any as type string. So I added a bit more logic.

I'm fine merging the prs together.

fabian-hiller · 2024-08-02T10:02:02Z

Ahh... So you recommend that I should also copy your entire ValidatorErrorKeyDotNotation type?

wmertens · 2024-08-02T10:28:04Z

Ahh... So you recommend that I should also copy your entire ValidatorErrorKeyDotNotation type?

I think that's a good idea

> > Co-authored-by: Tobi <[email protected]>

Co-authored-by: Tobi <[email protected]>

fabian-hiller · 2024-08-02T11:20:51Z

Done

tzdesign · 2024-08-02T11:57:24Z

@fabian-hiller perfect!

Thank you guys.

…#6752) * feat: add valibot$ validator and fix types of zod$ implementation * fix: brand typed data validators * fix: update API documentation of Qwik City * feat: copy code from PR #6720 to merge PRs Co-authored-by: Tobi <[email protected]> * fix: document change with changeset * chore: change version declaration of Valibot dependency * chore: change version declaration of Valibot dependency * fix: change text of changeset * chore: Add alpha preview warning to valibot$ API --------- Co-authored-by: Tobi <[email protected]>

fix(serrver-functions): omitted any from zod schemas

3d7dd5c

Typescript crashes because any could be infinite fix QwikDev#6719

tzdesign requested review from a team as code owners July 24, 2024 11:14

added docs

511c762

tzdesign changed the title ~~fix(server-functions): omitted any from zod schemas~~ fix(server-functions): omitted any from fieldErrors Jul 24, 2024

run fmt

271baaf

wmertens requested changes Jul 30, 2024

View reviewed changes

starters/apps/qwikcity-test/src/routes/(common)/actions/issue5463/index.tsx Outdated Show resolved Hide resolved

packages/qwik-city/runtime/src/types.ts Outdated Show resolved Hide resolved

Tobias Zimmermann added 2 commits August 1, 2024 09:44

added type tests for the validator error to server-functions.unit.ts

7767538

more specific name for any

246f45b

tzdesign requested a review from wmertens August 1, 2024 07:58

Tobias Zimmermann added 3 commits August 2, 2024 09:48

fixing the type omitting any but keep record types

62a930f

Merge remote-tracking branch 'upstream/main' into fix/fielderror-type

02e5723

reset package.json and api.update

0e16913

resetting package.json

8d39078

wmertens approved these changes Aug 2, 2024

View reviewed changes

fabian-hiller reviewed Aug 2, 2024

View reviewed changes

wmertens mentioned this pull request Aug 2, 2024

feat: add valibot$ validator and fix types of zod$ implementation #6752

Merged

7 tasks

fabian-hiller added a commit to fabian-hiller/qwik that referenced this pull request Aug 2, 2024

feat: copy code from PR QwikDev#6720 to merge PRs

c87183e

> > Co-authored-by: Tobi <[email protected]>

fabian-hiller added a commit to fabian-hiller/qwik that referenced this pull request Aug 2, 2024

feat: copy code from PR QwikDev#6720 to merge PRs

6f63fee

Co-authored-by: Tobi <[email protected]>

tzdesign closed this Aug 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(server-functions): omitted any from fieldErrors #6720

fix(server-functions): omitted any from fieldErrors #6720

tzdesign commented Jul 24, 2024

changeset-bot bot commented Jul 24, 2024 •

edited

Loading

netlify bot commented Jul 24, 2024 •

edited

Loading

tzdesign commented Jul 24, 2024

pkg-pr-new bot commented Jul 24, 2024 •

edited

Loading

tzdesign commented Aug 2, 2024

fabian-hiller commented Aug 2, 2024

wmertens left a comment

wmertens commented Aug 2, 2024

fabian-hiller Aug 2, 2024 •

edited

Loading

fabian-hiller commented Aug 2, 2024 •

edited

Loading

tzdesign commented Aug 2, 2024

fabian-hiller commented Aug 2, 2024 •

edited

Loading

wmertens commented Aug 2, 2024

fabian-hiller commented Aug 2, 2024

tzdesign commented Aug 2, 2024 •

edited

Loading

fix(server-functions): omitted any from fieldErrors #6720

fix(server-functions): omitted any from fieldErrors #6720

Conversation

tzdesign commented Jul 24, 2024

What is it?

Description

Checklist:

changeset-bot bot commented Jul 24, 2024 • edited Loading

⚠️ No Changeset found

netlify bot commented Jul 24, 2024 • edited Loading

‼️ Deploy request for qwik-insights rejected.

tzdesign commented Jul 24, 2024

pkg-pr-new bot commented Jul 24, 2024 • edited Loading

tzdesign commented Aug 2, 2024

fabian-hiller commented Aug 2, 2024

wmertens left a comment

Choose a reason for hiding this comment

wmertens commented Aug 2, 2024

fabian-hiller Aug 2, 2024 • edited Loading

Choose a reason for hiding this comment

fabian-hiller commented Aug 2, 2024 • edited Loading

tzdesign commented Aug 2, 2024

fabian-hiller commented Aug 2, 2024 • edited Loading

wmertens commented Aug 2, 2024

fabian-hiller commented Aug 2, 2024

tzdesign commented Aug 2, 2024 • edited Loading

changeset-bot bot commented Jul 24, 2024 •

edited

Loading

netlify bot commented Jul 24, 2024 •

edited

Loading

pkg-pr-new bot commented Jul 24, 2024 •

edited

Loading

fabian-hiller Aug 2, 2024 •

edited

Loading

fabian-hiller commented Aug 2, 2024 •

edited

Loading

fabian-hiller commented Aug 2, 2024 •

edited

Loading

tzdesign commented Aug 2, 2024 •

edited

Loading