Wrap function in cleanup function instead of returning it

QwikDev · Nov 14, 2023 · 8502210 · 8502210
1 parent 0c7c7e6
commit 8502210
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/packages/docs/src/routes/tutorial/events/synchronous/solution/app.tsx b/packages/docs/src/routes/tutorial/events/synchronous/solution/app.tsx
@@ -2,13 +2,13 @@ import { component$, useVisibleTask$, useSignal } from '@builder.io/qwik';
 
 export default component$(() => {
   const aHref = useSignal<Element>();
-  useVisibleTask$(() => {
+  useVisibleTask$(({cleanup}) => {
     const handler = (event: Event) => {
       event.preventDefault();
       window.open('http://qwik.builder.io');
     };
     aHref.value!.addEventListener('click', handler);
-    return () => aHref.value!.removeEventListener('click', handler);
+    cleanup(() => aHref.value!.removeEventListener('click', handler));
   });
 
   return (