fix: Add fallback error if window.top returns undefined #586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
indykoning
changed the title
indykoning
changed the title
|
Hi @indykoning thanks for your PR, can you fix the test pls? |
gioboa
reviewed
Apr 23, 2024
|
Thanks @indykoning for your help 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Fixes: #226
In some setups like Turbo window.top might no longer exist when checking if serializedValue Is Error while otherwise it is running fine.
This adds a fallback to an earlier stored Error Object so this error doesn't occur and normal analytics can proceed.
Checklist: