feat: access missing navigator properties #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
franpeza
force-pushed
the
fix-navigator
branch
from
2a5d444 to
b6d1b94
Compare
gioboa
changed the title
1 task
|
@franpeza Which integrations are you using? |
|
@gioboa in the project I collaborate we are using it with GTM integration that handles GA4 and some other third parties services. It is used mainly for ads. |
|
Nice, do you think we can mention them? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
Some third party integration we have tries to access a navigator's property that is defined in the top-level navigator (Navigator) instance but not in the worker navigator (WorkerNavigator).
In my case the properties are
javaEnabledandcookieEnabled.This should fix #414 and #270
Checklist: