Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typo in facebook-pixel page #524

Merged
merged 1 commit into from
Jan 6, 2024

Conversation

abdelsalamshahlol
Copy link
Contributor

What is it?

  • [✖️] Feature / enhancement
  • [✖️] Bug
  • [✅] Docs / tests

Description

Updated code example snippet and corrected an issue in code syntax.

Use cases and why

N/A

Checklist:

  • [ N/A] My code follows the developer guidelines of this project
  • [✅] I have performed a self-review of my own code
  • [✅] I have made corresponding changes to the documentation
  • [N/A] Added new tests to cover the fix / functionality

Updated code example snippet.
Copy link

vercel bot commented Dec 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 30, 2023 5:32pm

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @abdelsalamshahlol you rock 🚀

@gioboa gioboa changed the title Fixed error in code syntax docs: fix typo in facebook-pixel page Dec 30, 2023
@gioboa gioboa merged commit 1488e88 into QwikDev:main Jan 6, 2024
7 of 8 checks passed
@gioboa
Copy link
Member

gioboa commented Jan 6, 2024

Just for curiosity, what's your stack @abdelsalamshahlol ?

@abdelsalamshahlol
Copy link
Contributor Author

@gioboa Currently I'm focusing on Frontend and I use Angular, React, and Vue. But I also use Laravel and Express with MySQL for my side projects.

@gioboa
Copy link
Member

gioboa commented Jan 8, 2024

Is the application with Facebook Pixel a Laravel one?

@abdelsalamshahlol
Copy link
Contributor Author

No, it's an Angular app @gioboa

@gioboa
Copy link
Member

gioboa commented Jan 8, 2024

is the Angular guide good enough for you? Can we improve something?

@abdelsalamshahlol
Copy link
Contributor Author

@gioboa it was good for me but I think it's missing adding partytown script to scripts in package.json

@gioboa
Copy link
Member

gioboa commented Jan 11, 2024

May I suggest you to drop a PR for that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants