Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add document.scripts implementation #499

Closed
wants to merge 1 commit into from

Conversation

esjs
Copy link
Contributor

@esjs esjs commented Nov 15, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Currently we get an error if we try to access document.scripts.length, this happens because document.scripts returns undefined. Example:
document-scripts-issue

Use cases and why

Access to this scripts required by some 3rd party services that we use, for instance one of DoubleClick scripts
https://securepubads.g.doubleclick.net/pagead/managed/js/gpt/m202311090101/pubads_impl.js

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

Copy link

vercel bot commented Nov 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 15, 2023 2:33pm

Copy link
Member

@gioboa gioboa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks @esjs

@gioboa gioboa changed the title Add missing implementation for document.scripts feat: add document.scripts implementation Jan 7, 2024
@gioboa
Copy link
Member

gioboa commented Jan 7, 2024

This PR implemented the exact same thing 😅
Thanks @esjs for your help and commitment
I close this one.

@gioboa gioboa closed this Jan 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants