Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade rollup #464

Merged
merged 1 commit into from
Sep 15, 2023
Merged

chore: upgrade rollup #464

merged 1 commit into from
Sep 15, 2023

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Sep 14, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Upgrade Rollup from an older version

Use cases and why

Stop using deprecated rollup-plugin-terser package

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@vercel
Copy link

vercel bot commented Sep 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 14, 2023 8:25pm

Copy link
Contributor

@mhevery mhevery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution. This looks great! ❤️

May I know what is your motivation for the update? Did the previous rollup version cause problems for you?

@benmccann
Copy link
Contributor Author

It didn't directly cause me any issues, but I was working on another PR where I expect this would help.

@mhevery mhevery merged commit 9b92969 into QwikDev:main Sep 15, 2023
3 checks passed
@mhevery
Copy link
Contributor

mhevery commented Sep 15, 2023

Thank you. again!

@benmccann benmccann deleted the rollup branch September 15, 2023 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants