feat: allow specifying nonce in global config
#448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mhevery
approved these changes
Aug 25, 2023
| export interface PartytownProps extends PartytownConfig { | ||
| nonce?: string; | ||
| } | ||
| export interface PartytownProps extends PartytownConfig {} |
There was a problem hiding this comment.
why are we removing this property here?
There was a problem hiding this comment.
This was added recently in one of the commits. However, it only covered React configuration. Since 'nonce' is declared in the global config, there’s no need to retain the property in this interface, as it's already present in the extended interface.
This commit updates the signature of the `PartytownConfig` interface to include the `nonce` property. The `nonce` property can now be specified globally and will be subsequently set on `script` elements created by Partytown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is it?
Description
This commit updates the signature of the
PartytownConfiginterface to includethe
nonceproperty. Thenonceproperty can now be specified globally and will besubsequently set on
scriptelements created by Partytown.