Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support for nonce prop #416

Merged
merged 1 commit into from
Aug 2, 2023
Merged

feat: support for nonce prop #416

merged 1 commit into from
Aug 2, 2023

Conversation

hugotox
Copy link
Contributor

@hugotox hugotox commented Jun 1, 2023

What is it?

  • Feature / enhancement
  • Bug
  • Docs / tests

Description

Add an optional nonce prop to be applied to the script. Fixes #299

Use cases and why

Some users are using content security policies are required to append a nonce attribute to scripts, otherwise they won't be executed by the browser

Checklist:

  • My code follows the developer guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • Added new tests to cover the fix / functionality

@vercel
Copy link

vercel bot commented Jun 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
partytown ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 1, 2023 8:42pm

@tzdesign
Copy link

Hi guys,

are there any plans to merge this? We need this for our new qwik e-commerce implementation.
We have a very strict policy.

See ya

@mhevery mhevery merged commit 7d11794 into QwikDev:main Aug 2, 2023
@lop-Louis
Copy link

Hi, I notice there is a srcdoc iframe is created by partytown, but there is a script tag inside that are blocked by CSP. Is this happened due to nonce prop didn't correctly passed to inline srcdoc or there is some obvious configuration I have missed?

2024-07-26 13_10_31-Greenshot
2024-07-26 13_12_08-Greenshot

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add nonce to Partytown script for Content Security Policy
5 participants